Removal of superfluous test and code. Variable rename.

Author: filiplajszczak

pythonanywhere/api.py

@@ -227,17 +227,13 @@ def get_log_info(self):
                     response_text=response.text,
                 )
             )
-        if re.match(r"\[.*\]", response.text):
-            file_list = eval(response.text)
-        else:
-            raise Exception(
-                "GET log files info via API failed, got {text} instead of list of files".format(text=response.text))
+        file_list = response.json()
         log_types = ["access", "error", "server"]
         logs = {"access": [], "error": [], "server": []}
         log_prefix = "/var/log/{domain}.".format(domain=self.domain)
-        for file in file_list:
-            if type(file) == str and file.startswith(log_prefix):
-                log = file[len(log_prefix):].split(".")
+        for file_name in file_list:
+            if type(file_name) == str and file_name.startswith(log_prefix):
+                log = file_name[len(log_prefix):].split(".")
                 if log[0] in log_types:
                     log_type = log[0]
                     if log[-1] == "log":

tests/test_api.py

@@ -401,13 +401,3 @@ def test_raises_if_get_does_not_20x(self, api_responses, api_token):
 
         assert "GET log files info via API failed" in str(e.value)
         assert "nope" in str(e.value)
-
-    def test_raises_if_response_text_not_list(self, api_responses, api_token):
-        expected_url = get_api_endpoint().format(
-            username=getpass.getuser(), flavor="files") + "tree/?path=/var/log/"
-        api_responses.add(responses.GET, expected_url, status=200, body="print('Behold malicious code')")
-
-        with pytest.raises(Exception) as e:
-            Webapp("mydomain.com").get_log_info()
-
-        assert "GET log files info via API failed, got print('Behold malicious code')" in str(e.value)