makes sharing_post return message and file sharing link.

Author: filiplajszczak

pythonanywhere_core/files.py

@@ -119,16 +119,18 @@ def path_delete(self, path: str) -> int:
     def sharing_post(self, path: str) -> Tuple[int, str]:
         """Starts sharing a file at `path`.
 
-        Returns a tuple with a status code and sharing link on
-        success, raises otherwise.  Status code is 201 on success, 200
-        if file has been already shared."""
+        Returns a tuple with a message and sharing link on
+        success, raises otherwise.  Message is "successfully shared" on success,
+        "was already shared" if file has been already shared."""
 
         url = self.sharing_endpoint
 
         result = call_api(url, "POST", json={"path": path})
 
         if result.ok:
-            return result.status_code, result.json()["url"]
+            msg = {200: "was already shared", 201: "successfully shared"}[result.status_code]
+            sharing_url_suffix = result.json()["url"]
+            return msg, self._make_sharing_url(sharing_url_suffix)
 
         raise PythonAnywhereApiException(
             f"POST to {url} to share '{path}' failed, got {result}{self._error_msg(result)}"

tests/test_files.py

@@ -252,6 +252,7 @@ def test_sharing_post_returns_url_when_path_successfully_shared_or_has_been_shar
 ):
     valid_path = f"{home_dir_path}/README.txt"
     shared_url = f"/user/{username}/shares/asdf1234/"
+    sharing_url = urljoin(base_url.split("api")[0], shared_url)
     partial_response = dict(
         method=responses.POST,
         url=urljoin(base_url, "sharing/"),
@@ -264,13 +265,13 @@ def test_sharing_post_returns_url_when_path_successfully_shared_or_has_been_shar
     files = Files()
     first_share = files.sharing_post(valid_path)
 
-    assert first_share[0] == 201
-    assert first_share[1] == shared_url
+    assert first_share[0] == "successfully shared"
+    assert first_share[1] == sharing_url
 
     second_share = files.sharing_post(valid_path)
 
-    assert second_share[0] == 200
-    assert second_share[1] == shared_url
+    assert second_share[0] == "was already shared"
+    assert second_share[1] == sharing_url
 
 
 @pytest.mark.skip(reason="not implemented in the api yet")