Extracts static files mapping creation into separate method.

Author: filiplajszczak

pythonanywhere_core/webapp.py

@@ -88,14 +88,22 @@ def create(self, python_version: str, virtualenv_path: Path, project_path: Path,
                 "PATCH to set virtualenv path and source directory via API failed," f"got {response}:{response.text}"
             )
 
+    def create_static_file_mapping(self, url_path: str, directory_path: Path) -> None:
+        """Create a static file mapping via the API.
+
+        :param url_path: URL path (e.g., '/static/')
+        :param directory_path: Filesystem path to serve (as Path)
+        """
+        url = f"{self.domain_url}static_files/"
+        call_api(url, "post", json=dict(url=url_path, path=str(directory_path)))
+
     def add_default_static_files_mappings(self, project_path: Path) -> None:
         """Add default static files mappings for /static/ and /media/
 
         :param project_path: path to the project
         """
-        url = f"{self.domain_url}static_files/"
-        call_api(url, "post", json=dict(url="/static/", path=str(Path(project_path) / "static")))
-        call_api(url, "post", json=dict(url="/media/", path=str(Path(project_path) / "media")))
+        self.create_static_file_mapping("/static/", Path(project_path) / "static")
+        self.create_static_file_mapping("/media/", Path(project_path) / "media")
 
     def reload(self) -> None:
         """Reload webapp

tests/test_webapp.py

@@ -1,6 +1,7 @@
 import getpass
 import json
 from datetime import datetime
+from pathlib import Path
 
 import pytest
 import responses
@@ -209,31 +210,37 @@ def test_ignores_404_from_delete_call_when_nuking(api_responses, api_token, base
     webapp.create("3.10", "/virtualenv/path", "/project/path", nuke=True)
 
 
-def test_does_two_posts_to_static_files_endpoint(api_token, api_responses, domain_url, webapp):
+def test_create_static_file_mapping_posts_correctly(api_token, api_responses, domain_url, webapp):
     static_files_url = f"{domain_url}static_files/"
     api_responses.add(responses.POST, static_files_url, status=201)
-    api_responses.add(responses.POST, static_files_url, status=201)
 
-    webapp.add_default_static_files_mappings("/project/path")
+    webapp.create_static_file_mapping("/assets/", "/project/assets")
 
-    post1 = api_responses.calls[0]
-    assert post1.request.url == static_files_url
-    assert post1.request.headers["content-type"] == "application/json"
-    assert post1.request.headers["Authorization"] == f"Token {api_token}"
-    assert json.loads(post1.request.body.decode("utf8")) == {
-        "url": "/static/",
-        "path": "/project/path/static",
-    }
-    post2 = api_responses.calls[1]
-    assert post2.request.url == static_files_url
-    assert post2.request.headers["content-type"] == "application/json"
-    assert post2.request.headers["Authorization"] == f"Token {api_token}"
-    assert json.loads(post2.request.body.decode("utf8")) == {
-        "url": "/media/",
-        "path": "/project/path/media",
+    post = api_responses.calls[0]
+    assert post.request.url == static_files_url
+    assert post.request.headers["content-type"] == "application/json"
+    assert post.request.headers["Authorization"] == f"Token {api_token}"
+    assert json.loads(post.request.body.decode("utf8")) == {
+        "url": "/assets/",
+        "path": "/project/assets",
     }
 
 
+def test_adds_default_static_files_mappings(mocker, webapp):
+    mock_create = mocker.patch.object(webapp, "create_static_file_mapping")
+
+    project_path = "/directory/path"
+    webapp.add_default_static_files_mappings(project_path)
+
+    mock_create.assert_has_calls(
+        [
+            mocker.call("/static/", Path(project_path) / "static"),
+            mocker.call("/media/", Path(project_path) / "media"),
+        ]
+    )
+
+
+
 def test_does_post_to_reload_url(api_responses, api_token, domain_url, webapp):
     reload_url = f"{domain_url}reload/"
     api_responses.add(responses.POST, reload_url, status=200)