Removes snakesay.

Author: filiplajszczak

poetry.lock

@@ -13,6 +13,7 @@ classifiers = [
     "Intended Audience :: Developers",
     "Topic :: Software Development :: Libraries",
     "License :: OSI Approved :: MIT License",
+    "Programming Language :: Python :: 3.14",
     "Programming Language :: Python :: 3.13",
     "Programming Language :: Python :: 3.12",
     "Programming Language :: Python :: 3.11",
@@ -24,7 +25,6 @@ keywords = ["pythonanywhere", "api", "cloud", "web hosting"]
 python = "^3.10"
 python-dateutil = "^2.8.2"
 requests = "^2.30.0"
-snakesay = "^0.10.3"
 typing_extensions = "^4.5.0"
 
 [tool.poetry.group.dev.dependencies]

pyproject.toml

@@ -15,4 +15,14 @@ class NoTokenError(PythonAnywhereApiException):
 
 
 class DomainAlreadyExistsException(PythonAnywhereApiException):
-    pass
+    pass
+
+
+class MissingCNAMEException(PythonAnywhereApiException):
+    def __init__(self):
+        super().__init__(
+            "Could not find a CNAME for your website. If you're using an A record, "
+            "CloudFlare, or some other way of pointing your domain at PythonAnywhere "
+            "then that should not be a problem. If you're not, you should double-check "
+            "your DNS setup."
+        )

pythonanywhere_core/exceptions.py

@@ -7,10 +7,9 @@
 from typing import Any
 
 from dateutil.parser import parse
-from snakesay import snakesay
 
 from pythonanywhere_core.base import call_api, get_api_endpoint, PYTHON_VERSIONS
-from pythonanywhere_core.exceptions import SanityException, PythonAnywhereApiException
+from pythonanywhere_core.exceptions import SanityException, PythonAnywhereApiException, MissingCNAMEException
 
 
 class Webapp:
@@ -54,7 +53,6 @@ def sanity_checks(self, nuke: bool) -> None:
 
         :raises SanityException: if API token is missing or webapp already exists
         """
-        print(snakesay("Running API sanity checks"))
         token = os.environ.get("API_TOKEN")
         if not token:
             raise SanityException(
@@ -127,24 +125,13 @@ def add_default_static_files_mappings(self, project_path: Path) -> None:
     def reload(self) -> None:
         """Reload webapp
 
+        :raises MissingCNAMEException: if CNAME not found (reload succeeded)
         :raises PythonAnywhereApiException: if API call fails"""
         url = f"{self.domain_url}reload/"
         response = call_api(url, "post")
         if not response.ok:
             if response.status_code == 409 and response.json()["error"] == "cname_error":
-                print(
-                    snakesay(
-                        dedent(
-                            """
-                            Could not find a CNAME for your website.  If you're using an A record,
-                            CloudFlare, or some other way of pointing your domain at PythonAnywhere
-                            then that should not be a problem.  If you're not, you should double-check
-                            your DNS setup.
-                        """
-                        )
-                    )
-                )
-                return
+                raise MissingCNAMEException()
             raise PythonAnywhereApiException(f"POST to reload webapp via API failed, got {response}:{response.text}")
 
     def set_ssl(self, certificate: str, private_key: str) -> None:
@@ -155,7 +142,6 @@ def set_ssl(self, certificate: str, private_key: str) -> None:
 
         :raises PythonAnywhereApiException: if API call fails
         """
-        print(snakesay(f"Setting up SSL for {self.domain} via API"))
         url = f"{self.domain_url}ssl/"
         response = call_api(url, "post", json={"cert": certificate, "private_key": private_key})
         if not response.ok:
@@ -193,12 +179,6 @@ def delete_log(self, log_type: str, index: int = 0) -> None:
 
         :raises PythonAnywhereApiException: if API call fails
         """
-        if index:
-            message = f"Deleting old (archive number {index}) {log_type} log file for {self.domain} via API"
-        else:
-            message = f"Deleting current {log_type} log file for {self.domain} via API"
-        print(snakesay(message))
-
         if index == 1:
             suffix = ".1"
         elif index > 1:

pythonanywhere_core/webapp.py

@@ -9,7 +9,7 @@
 from urllib.parse import urlencode
 
 from pythonanywhere_core.base import get_api_endpoint, PYTHON_VERSIONS
-from pythonanywhere_core.exceptions import SanityException, PythonAnywhereApiException
+from pythonanywhere_core.exceptions import SanityException, PythonAnywhereApiException, MissingCNAMEException
 from pythonanywhere_core.webapp import Webapp
 
 
@@ -298,7 +298,7 @@ def test_raises_if_post_does_not_20x_that_is_not_a_cname_error(api_responses, ap
     assert "nope" in str(e.value)
 
 
-def test_does_not_raise_if_post_responds_with_a_cname_error(api_responses, api_token, domain_url, webapp):
+def test_raises_missing_cname_exception_on_cname_error(api_responses, api_token, domain_url, webapp):
     reload_url = f"{domain_url}reload/"
     api_responses.add(
         responses.POST,
@@ -307,7 +307,10 @@ def test_does_not_raise_if_post_responds_with_a_cname_error(api_responses, api_t
         json={"status": "error", "error": "cname_error"},
     )
 
-    webapp.reload()  # Should not raise
+    with pytest.raises(MissingCNAMEException) as e:
+        webapp.reload()
+
+    assert "Could not find a CNAME for your website" in str(e.value)
 
 
 # SET SSL