Fix init validation + add tests

Author: pushfoo

arcade/camera/camera_2d.py

@@ -72,7 +72,7 @@ def __init__(self, *,
                 raise ZeroProjectionDimension((
                     f"projection width is 0 due to equal {left=}"
                     f"and {right=} values"))
-            bottom, top = projection_data.left, projection_data.right
+            bottom, top = projection_data.bottom, projection_data.top
             if bottom == top:
                 raise ZeroProjectionDimension((
                     f"projection height is 0 due to equal {bottom=}"

tests/unit/camera/test_camera2d.py

@@ -4,7 +4,7 @@
 
 from arcade import Window
 from arcade.camera import Camera2D
-from arcade.camera.data_types import ZeroProjectionDimension
+from arcade.camera.data_types import ZeroProjectionDimension, OrthographicProjectionData
 
 
 class Camera2DSub1(Camera2D):
@@ -33,8 +33,19 @@ def camera_class(request):
     (5., 5., 5., 5.)
 ]
 
+NEAR_FAR_VALUES = [-50.,0.,50.]
+
+
+@pytest.fixture(params=AT_LEAST_ONE_EQUAL_VIEWPORT_DIMENSION)
+def bad_projection(request):
+    return request.param
+
+
+@pytest.fixture(params=NEAR_FAR_VALUES)
+def same_near_far(request):
+    return request.param
+
 
-@pytest.mark.parametrize("bad_projection", AT_LEAST_ONE_EQUAL_VIEWPORT_DIMENSION)
 def test_camera2d_from_raw_data_projection_xy_pairs_equal_raises_zeroprojectiondimension(
     window: Window,
     bad_projection: Tuple[float, float, float, float],  # Clarify type for PyCharm
@@ -44,18 +55,34 @@ def test_camera2d_from_raw_data_projection_xy_pairs_equal_raises_zeroprojectiond
         camera_class.from_raw_data(projection=bad_projection)
 
 
+def test_camera2d_init_xy_pairs_equal_raises_zeroprojectiondimension(
+    window: Window,
+    bad_projection: Tuple[float, float, float, float],
+    camera_class
+):
+    data = OrthographicProjectionData(
+        *bad_projection, -100.0, 100.0,
+        viewport=(0,0, 800, 600)
+    )
+
+    with pytest.raises(ZeroProjectionDimension):
+        _ = Camera2D(projection_data=data)
+
 
 def test_camera2d_from_raw_data_equal_near_far_raises_zeroprojectiondimension(
-        window: Window, camera_class
+        window: Window,
+        same_near_far: float,
+        camera_class
 ):
     with pytest.raises(ZeroProjectionDimension):
-        camera_class.from_raw_data(near=-100, far=-100)
+        camera_class.from_raw_data(near=near_far, far=near_far)
 
     with pytest.raises(ZeroProjectionDimension):
-        camera_class.from_raw_data(near=0, far=0)
+        camera_class.from_raw_data(near=near_far, far=near_far)
 
     with pytest.raises(ZeroProjectionDimension):
-        camera_class.from_raw_data(near=100, far=100)
+        camera_class.from_raw_data(near=near_far, far=near_far)
+
 
 
 @pytest.mark.parametrize("camera_class", CAMERA2D_SUBS)