More typing fixes

Author: Cleptomania

arcade/examples/gui/exp_controller_inventory.py

@@ -412,8 +412,8 @@ def on_draw_before_ui(self):
 
 if __name__ == "__main__":
     # pixelate the font
-    pyglet.font.base.Font.texture_min_filter = GL_NEAREST
-    pyglet.font.base.Font.texture_mag_filter = GL_NEAREST
+    pyglet.font.base.Font.texture_min_filter = GL_NEAREST  # type: ignore
+    pyglet.font.base.Font.texture_mag_filter = GL_NEAREST  # type: ignore
 
     load_kenney_fonts()
 

arcade/examples/input_manager.py

@@ -1,10 +1,10 @@
+#  type: ignore
 """
 Example for handling input using the Arcade InputManager
 
 If Python and Arcade are installed, this example can be run from the command line with:
 python -m arcade.examples.input_manager
 """
-#  type: ignore
 import random
 from collections.abc import Sequence
 

arcade/future/video/video_player.py

@@ -77,10 +77,10 @@ def get_video_size(self) -> tuple[int, int]:
         width = video_format.width
         height = video_format.height
         if video_format.sample_aspect > 1:
-            width *= video_format.sample_aspect
+            width = int(width * video_format.sample_aspect)
         elif video_format.sample_aspect < 1:
-            height /= video_format.sample_aspect
-        return int(width), int(height)
+            height = int(height / video_format.sample_aspect)
+        return width, height
 
 
 class VideoPlayerView(arcade.View):

arcade/perf_graph.py

@@ -1,7 +1,9 @@
 import random
 
 import pyglet.clock
-from pyglet.graphics import Batch
+
+# Pyright can't figure out the dynamic import for the backends in Pyglet
+from pyglet.graphics import Batch  # type: ignore
 from pyglet.shapes import Line
 
 import arcade

arcade/pymunk_physics_engine.py

@@ -776,7 +776,7 @@ def check_grounding(self, sprite: Sprite) -> dict:
         """
         grounding = {
             "normal": pymunk.Vec2d.zero(),
-            "penetration": pymunk.Vec2d.zero(),
+            "penetration": 0.0,
             "impulse": pymunk.Vec2d.zero(),
             "position": pymunk.Vec2d.zero(),
             "body": None,
@@ -806,7 +806,9 @@ def f(arbiter: pymunk.Arbiter):
             ):
                 grounding["normal"] = n
                 grounding["penetration"] = -arbiter.contact_point_set.points[0].distance
-                grounding["body"] = arbiter.shapes[1].body
+                # Mypy is making bad inferences about what this is based on the other elements
+                # and this doesn't particularly feel worth a TypedDict
+                grounding["body"] = arbiter.shapes[1].body  # type: ignore
                 grounding["impulse"] = arbiter.total_impulse
                 grounding["position"] = arbiter.contact_point_set.points[0].point_b
 

arcade/text.py

@@ -8,6 +8,10 @@
 import pyglet
 from pyglet.enums import Style, Weight
 
+# Pyright can't figure out the dynamic backend imports in pyglet.graphics
+# right now. Maybe can fix in future Pyglet version
+from pyglet.graphics import Batch, Group  # type: ignore
+
 import arcade
 from arcade.exceptions import PerformanceWarning, warning
 from arcade.resources import resolve
@@ -216,8 +220,8 @@ def __init__(
         anchor_y: str = "baseline",
         multiline: bool = False,
         rotation: float = 0,
-        batch: pyglet.graphics.Batch | None = None,
-        group: pyglet.graphics.Group | None = None,
+        batch: Batch | None = None,
+        group: Group | None = None,
         z: float = 0,
         **kwargs,
     ):
@@ -297,19 +301,19 @@ def __exit__(self, exc_type, exc_val, exc_tb):
         self.label.end_update()
 
     @property
-    def batch(self) -> pyglet.graphics.Batch | None:
+    def batch(self) -> Batch | None:
         """The batch this text is in, if any.
 
         Can be unset by setting to ``None``.
         """
         return self.label.batch
 
     @batch.setter
-    def batch(self, batch: pyglet.graphics.Batch):
+    def batch(self, batch: Batch):
         self.label.batch = batch
 
     @property
-    def group(self) -> pyglet.graphics.Group | None:
+    def group(self) -> Group | None:
         """
         The specific group in a batch the text should belong to.
 
@@ -320,7 +324,7 @@ def group(self) -> pyglet.graphics.Group | None:
         return self.label.group
 
     @group.setter
-    def group(self, group: pyglet.graphics.Group):
+    def group(self, group: Group):
         self.label.group = group
 
     @property

tests/unit/test_example_docstrings.py

@@ -62,6 +62,8 @@ def check_submodules(parent_module_absolute_name: str) -> None:
 
     # Check all modules nested immediately inside it on the file system
     for finder, child_module_name, is_pkg in pkgutil.iter_modules(parent_module_file_path):
+        if is_pkg:
+            continue
         child_module_file_path = Path(finder.path) / f"{child_module_name}.py"
         child_module_absolute_name = f"{parent_module_absolute_name}.{child_module_name}"