Bug/typo fix + test tweaks

Author: pushfoo

arcade/sprite/base.py

@@ -352,17 +352,21 @@ def rgb(self) -> Tuple[int, int, int]:
     @rgb.setter
     def rgb(self, color: RGBOrA255):
 
-        # Fast validation by unpacking into channel values + unused
+        # Fast validation of size by unpacking channel values
         try:
-            r, g, b, *_ = color
-        except ValueError as _:
-            raise ValueError(
-                f"{self.__class__.__name__},rgb takes 3 or 4 channels")
+            r, g, b, *_a = color
+            if len(_a) > 1:  # Alpha's only used to validate here
+                raise ValueError()
+
+        except ValueError as _:  # It's always a length issue
+            raise ValueError((
+                f"{self.__class__.__name__},rgb takes 3 or 4 channel"
+                f" colors, but got {len(color)} channels"))
 
         # Unpack to avoid index / . overhead & prep for repack
-        current_r, current_g, current_g, a = self._color
+        current_r, current_b, current_g, a = self._color
 
-        # Early exit if equivalent
+        # Do nothing if equivalent to current color
         if current_r == r and current_g == g and current_b == b:
             return
 

tests/unit/sprite/test_sprite.py

@@ -336,12 +336,22 @@ def test_visible():
     assert sprite.alpha == 100
 
 
-def test_sprite_rgb_property():
+def test_sprite_rgb_property_basics():
     sprite = arcade.Sprite(":resources:images/animated_characters/female_person/femalePerson_idle.png")
 
     # Initial multiply tint is white
     assert sprite.rgb == (255, 255, 255)
 
+    # Values which are too short are not allowed
+    with pytest.raises(ValueError):
+        sprite.rgb = (1,2)
+    with pytest.raises(ValueError):
+        sprite.rgb = (0,)
+
+    # Nor are values which are too long
+    with pytest.raises(ValueError):
+        sprite.rgb = (100,100,100,100,100)
+
     # Test color setting + .rgb report when .visible == True
     sprite.rgb = (1, 3, 5, 7)
     assert sprite.color.r == 1