Skip to content

Commit c3fc790

Browse files
remove fixed TODOs
1 parent 07580da commit c3fc790

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

pythonbpf/allocation_pass.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -242,21 +242,12 @@ def _allocate_for_attribute(builder, var_name, rval, local_sym_tab, structs_sym_
242242
)
243243
field_ir, field = field_type
244244
# TODO: For now, we only support integer type allocations.
245-
246-
# loaded_value = builder.load(field_ir, align=8)
247-
# #TODO: fatal flaw that this always assumes first argument of function to be the context of what this gets.
245+
# This always assumes first argument of function to be the context struct
248246
base_ptr = builder.function.args[0]
249247
local_sym_tab[
250248
struct_var
251249
].var = base_ptr # This is repurposing of var to store the pointer of the base type
252250
local_sym_tab[struct_var].ir_type = field_ir
253-
# gep_result = builder.gep(
254-
# base_ptr,
255-
# [loaded_value],
256-
# inbounds=False, # Not using inbounds GEP
257-
# )
258-
# print("DEBUG", loaded_value, base_ptr, gep_result)
259-
# Use i64 for allocation since that's what the global variable contains
260251

261252
actual_ir_type = ir.IntType(64)
262253

0 commit comments

Comments
 (0)