Skip to content

Commit 1079b39

Browse files
committed
Catch PSR doesnotexist before checking for votes
1 parent 1528559 commit 1079b39

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

junction/proposals/templatetags/proposal_filters.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,15 @@ def reviewer_comments(proposal, user):
2222
def is_reviewer_voted(proposal, user, phase=None):
2323
if not phase:
2424
phase = PSRVotePhase.PRIMARY
25+
2526
try:
26-
vote = ProposalSectionReviewerVote.objects.get(
27-
proposal=proposal,
28-
voter=ProposalSectionReviewer.objects.get(
29-
conference_reviewer__reviewer=user,
30-
conference_reviewer__conference=proposal.conference,
31-
proposal_section=proposal.proposal_section),
32-
phase=phase,
27+
voter = ProposalSectionReviewer.objects.get(
28+
conference_reviewer__reviewer=user,
29+
conference_reviewer__conference=proposal.conference,
30+
proposal_section=proposal.proposal_section
3331
)
34-
except ProposalSectionReviewerVote.DoesNotExist:
32+
vote = ProposalSectionReviewerVote.objects.get(proposal=proposal, voter=voter, phase=phase)
33+
except (ProposalSectionReviewer.DoesNotExist, ProposalSectionReviewerVote.DoesNotExist):
3534
vote = None
3635

3736
return vote

0 commit comments

Comments
 (0)