lint: Add pre-commit for linters

pradyunsg · pradyunsg · commit 29682c06531d · 2020-03-24T16:19:55.000+05:30
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -0,0 +1,12 @@
+repos:
+- repo: https://github.com/pre-commit/pre-commit-hooks
+  rev: v2.5.0
+  hooks:
+  - id: check-builtin-literals
+  - id: check-added-large-files
+  - id: check-case-conflict
+  - id: check-yaml
+  - id: debug-statements
+  - id: end-of-file-fixer
+  - id: forbid-new-submodules
+  - id: trailing-whitespace
diff --git a/junction/static/fonts/fontawesome-webfont.svg b/junction/static/fonts/fontawesome-webfont.svg
@@ -517,4 +517,4 @@
 <glyph unicode="&#xf20e;" horiz-adv-x="1792" />
 <glyph unicode="&#xf500;" horiz-adv-x="1792" />
 </font>
-</defs></svg> 
+</defs></svg>
diff --git a/junction/static/fonts/glyphicons-halflings-regular.svg b/junction/static/fonts/glyphicons-halflings-regular.svg
@@ -226,4 +226,4 @@
 <glyph unicode="&#xe199;" d="M100 200h400v-155l-75 -45h350l-75 45v155h400l-270 300h170l-270 300h170l-300 333l-300 -333h170l-270 -300h170z" />
 <glyph unicode="&#xe200;" d="M121 700q0 -53 28.5 -97t75.5 -65q-4 -16 -4 -38q0 -74 52.5 -126.5t126.5 -52.5q56 0 100 30v-306l-75 -45h350l-75 45v306q46 -30 100 -30q74 0 126.5 52.5t52.5 126.5q0 24 -9 55q50 32 79.5 83t29.5 112q0 90 -61.5 155.5t-150.5 71.5q-26 89 -99.5 145.5 t-167.5 56.5q-116 0 -197.5 -81.5t-81.5 -197.5q0 -4 1 -11.5t1 -11.5q-14 2 -23 2q-74 0 -126.5 -52.5t-52.5 -126.5z" />
 </font>
-</defs></svg> 
+</defs></svg>
diff --git a/junction/static/fonts/icomoon.svg b/junction/static/fonts/icomoon.svg
@@ -14,4 +14,4 @@
 <glyph unicode="&#xe604;" d="M384 160v64h-160v64h160v64l96-96zM352 192v-128h-160v-96l-192 96v416h352v-160h-32v128h-256l128-64v-288h128v96z" />
 <glyph unicode="&#xe605;" d="M394.767 448c0 0-100.478 0-133.97 0-60.061 0-116.585-45.503-116.585-98.211 0-53.863 40.941-97.333 102.044-97.333 4.249 0 8.378 0.085 12.42 0.376-3.964-7.593-6.8-16.144-6.8-25.021 0-14.969 8.052-27.105 18.234-37.012-7.693 0-15.121-0.224-23.226-0.224-74.391 0.001-131.65-47.38-131.65-96.511 0-48.389 62.771-78.656 137.167-78.656 84.812 0 131.653 48.122 131.653 96.514 0 38.801-11.448 62.036-46.843 87.067-12.108 8.571-35.266 29.418-35.266 41.672 0 14.36 4.098 21.434 25.714 38.323 22.156 17.312 37.837 41.651 37.837 69.958 0 33.703-15.011 66.549-43.187 77.386h42.478l29.98 21.672zM347.974 120.271c1.063-4.486 1.642-9.104 1.642-13.814 0-39.1-25.195-69.655-97.487-69.655-51.421 0-88.558 32.552-88.558 71.65 0 38.321 46.063 70.222 97.482 69.666 12-0.127 23.184-2.058 33.334-5.345 27.914-19.414 47.938-30.38 53.587-52.502zM265.643 266.112c-34.519 1.032-67.318 38.613-73.276 83.93-5.958 45.333 17.185 80.021 51.694 78.995 34.504-1.037 67.318-37.407 73.279-82.729 5.953-45.33-17.195-81.229-51.697-80.196z" />
 <glyph unicode="&#xe606;" d="M256 480c-141.385 0-256-114.615-256-256s114.615-256 256-256 256 114.615 256 256-114.615 256-256 256zM208 64l-106 138 47 49 59-75 185 151 23-23-208-240z" />
-</font></defs></svg>
+</font></defs></svg>
diff --git a/junction/static/js/Chart.min.js b/junction/static/js/Chart.min.js
diff --git a/junction/static/js/bootstrap-markdown.js b/junction/static/js/bootstrap-markdown.js
@@ -1037,7 +1037,7 @@
 
             if (link != null && link != '' && link != 'http://' && link.substr(0,4) == 'http') {
               var sanitizedLink = $('<div>'+link+'</div>').text()
-              
+
               // transform selection and set the cursor into chunked text
               e.replaceSelection('!['+chunk+']('+sanitizedLink+' "'+e.__localize('enter image title here')+'")')
               cursor = selected.start+2
diff --git a/junction/static/js/bootstrap.min.js b/junction/static/js/bootstrap.min.js
diff --git a/junction/static/js/jquery-1.11.0.js b/junction/static/js/jquery-1.11.0.js
diff --git a/junction/static/js/markdown.js b/junction/static/js/markdown.js
@@ -1613,4 +1613,4 @@ function merge_text_nodes( jsonml ) {
   else {
     return exports;
   }
-} )() );
+} )() );
diff --git a/junction/static/js/sweetalert.min.js b/junction/static/js/sweetalert.min.js
diff --git a/junction/static/less/vendor.less b/junction/static/less/vendor.less
@@ -1,2 +1,2 @@
 @import "../bower_components/bootstrap/less/bootstrap.less";
-@import "../bower_components/font-awesome/less/font-awesome.less";
+@import "../bower_components/font-awesome/less/font-awesome.less";
diff --git a/junction/templates/account/account_inactive.html b/junction/templates/account/account_inactive.html
@@ -21,5 +21,3 @@ <h2 class="fill-blue text-center">{% trans "Account Inactive" %}</h2>
         </div>
     </div>
 {% endblock %}
-
-
diff --git a/junction/templates/account/email/password_reset_key_subject.txt b/junction/templates/account/email/password_reset_key_subject.txt
@@ -1,4 +1,4 @@
 {% load i18n %}
 {% autoescape off %}
 {% blocktrans %}Password Reset E-mail{% endblocktrans %}
-{% endautoescape %}
+{% endautoescape %}
diff --git a/junction/templates/account/email_confirm.html b/junction/templates/account/email_confirm.html
@@ -39,7 +39,3 @@ <h2 class="fill-blue text-center">{% trans "Confirm E-mail Address" %}</h2>
         </div>
     </div>
 {% endblock %}
-
-
-
-
diff --git a/junction/templates/account/logout.html b/junction/templates/account/logout.html
@@ -30,5 +30,3 @@ <h2 class="fill-blue text-center">{% trans "Sign Out" %}</h2>
         </div>
     </div>
 {% endblock %}
-
-
diff --git a/junction/templates/account/messages/password_changed.txt b/junction/templates/account/messages/password_changed.txt
@@ -1,3 +1,2 @@
 {% load i18n %}
 {% blocktrans %}Password successfully changed.{% endblocktrans %}
-
diff --git a/junction/templates/account/messages/password_set.txt b/junction/templates/account/messages/password_set.txt
@@ -1,3 +1,2 @@
 {% load i18n %}
 {% blocktrans %}Password successfully set.{% endblocktrans %}
-
diff --git a/junction/templates/account/password_reset_from_key.html b/junction/templates/account/password_reset_from_key.html
@@ -35,5 +35,3 @@ <h2 class="fill-blue text-center">{% if token_fail %}{% trans "Bad Token" %}{% e
         </div>
     </div>
 {% endblock %}
-
-
diff --git a/junction/templates/account/password_reset_from_key_done.html b/junction/templates/account/password_reset_from_key_done.html
@@ -22,5 +22,3 @@ <h2 class="fill-blue text-center">{% trans "Change Password" %}</h2>
         </div>
     </div>
 {% endblock %}
-
-
diff --git a/junction/templates/account/password_set.html b/junction/templates/account/password_set.html
@@ -27,5 +27,3 @@ <h2 class="fill-blue text-center">{% trans "Set Password" %}</h2>
         </div>
     </div>
 {% endblock %}
-
-
diff --git a/junction/templates/account/signup_closed.html b/junction/templates/account/signup_closed.html
@@ -23,5 +23,3 @@ <h2 class="fill-blue text-center">{% trans "Sign Up Closed" %}</h2>
         </div>
     </div>
 {% endblock %}
-
-
diff --git a/junction/templates/proposals/email/upload_content/message.txt b/junction/templates/proposals/email/upload_content/message.txt
@@ -6,11 +6,10 @@ We understand that you might feel that its too early to upload the presentation
 
 If you have proposed a workshop, do share the draft version of the content you are planning to present in ppt or pdf format, code snippets can be added later.
 
-Looking forward to seeing you in {{ conference.name }}. 
+Looking forward to seeing you in {{ conference.name }}.
 
 Thanks,  <br />
 {{ conference.name }} Team  <br /><br />
 
 -------------------------------------------------------------------------------
 PS: Please, don't reply to the email.  You can login ({{host}}{{login_url}}) to add content to proposal.
-
diff --git a/junction/templates/proposals/review.html b/junction/templates/proposals/review.html
@@ -55,7 +55,7 @@ <h4 class="fill-blue text-center">Proposal Voting</h4>
                         </div>
                     </form>
                 </div>
-                
+
                 <hr class="hr-mini">
                 <div class="row">
                     <h4 class="fill-blue text-center">Review Proposal</h4>
diff --git a/junction/templates/socialaccount/base.html b/junction/templates/socialaccount/base.html
@@ -1,2 +1 @@
 {% extends "account/base.html" %}
-
diff --git a/junction/templates/socialaccount/connections.html b/junction/templates/socialaccount/connections.html
@@ -52,4 +52,3 @@ <h2 class="fill-blue text-center">{% trans "Account Connections" %}</h2>
         </div>
     </div>
 {% endblock %}
-
diff --git a/junction/templates/socialaccount/snippets/login_extra.html b/junction/templates/socialaccount/snippets/login_extra.html
@@ -1,4 +1,3 @@
 {% load socialaccount %}
 
 {% providers_media_js %}
-
diff --git a/junction/templates/socialaccount/snippets/provider_list.html b/junction/templates/socialaccount/snippets/provider_list.html
@@ -19,4 +19,3 @@
          <span class="name">{{provider.name}}</span>
     </a>
 {% endfor %}
-
diff --git a/junction/tickets/templates/sync_data.html b/junction/tickets/templates/sync_data.html
@@ -10,6 +10,5 @@
                 <button type="submit">
 			Sync data
 		</button>
-	</form>	
+	</form>
 {% endblock %}
-
diff --git a/junction/tickets/templates/sync_data.html~ b/junction/tickets/templates/sync_data.html~
@@ -7,6 +7,5 @@
                 <button type="submit">
 			Sync data
 		</button>
-	</form>	
+	</form>
 {% endblock %}
-
diff --git a/setup.cfg b/setup.cfg
@@ -30,4 +30,3 @@ omit =
 [coverage:report]
 show_missing = False
 skip_covered = True
-
diff --git a/tests/unit/tickets/management/commands/test_sync_data.py b/tests/unit/tickets/management/commands/test_sync_data.py
@@ -9,45 +9,45 @@ def none_events():
 
 
 def single_event():
-    list_of_event = list()
-    list_of_event.append(
-        {"eventId": "EKDJHH", "eventTitle ": "My Demo Event", })
-    return list_of_event
+    return [{"eventId": "EKDJHH", "eventTitle ": "My Demo Event"}]
 
 
 def none_order():
     return None
 
 
 def single_order():
-    order = dict()
-    order["orderNo"] = "E4CACBXXXXX528384A20C930"
-    order["orderCost"] = "127.19"
-    order["quantity"] = "2"
-    order["status"] = "success"
-    order["paidBy"] = "online"
-    order["paidTo"] = None
-    order["refundAmount"] = None
-    order["purchaseDate"] = "2013-11-13"
-    order["name"] = "PankajKumar"
-    order["email"] = "dummy@mydummydomain.com"
-    order["city"] = "Pune"
-    order["state"] = "Maharashtra"
-    order["country"] = "India"
-    order["address"] = "address"
-    order["zipcode"] = "411027"
-    order["phoneNo"] = "22222"
-    order["attendee"] = [{"ticketName": "Free Visit",
-                          "ticketId": "TKEFAJC",
-                          "name": "Pankaj Kumar",
-                          "email": "dummy@mydummydomain.com",
-                          "checkin": "no",
-                          "ticketNo": "E4CACB-694",
-                          "status": "attending",
-                          "details": {"Date": ""}}]
-    list_of_order = list()
-    list_of_order.append(order)
-    return list_of_order
+    order = {
+        "orderNo": "E4CACBXXXXX528384A20C930",
+        "orderCost": "127.19",
+        "quantity": "2",
+        "status": "success",
+        "paidBy": "online",
+        "paidTo": None,
+        "refundAmount": None,
+        "purchaseDate": "2013-11-13",
+        "name": "Pankaj Kumar",
+        "email": "dummy@mydummydomain.com",
+        "city": "Pune",
+        "state": "Maharashtra",
+        "country": "India",
+        "address": "address",
+        "zipcode": "411027",
+        "phoneNo": "22222",
+        "attendee": [
+            {
+                "ticketName": "Free Visit",
+                "ticketId": "TKEFAJC",
+                "name": "Pankaj Kumar",
+                "email": "dummy@mydummydomain.com",
+                "checkin": "no",
+                "ticketNo": "E4CACB-694",
+                "status": "attending",
+                "details": {"Date": ""}
+            }
+        ]
+    }
+    return [order]
 
 
 def single_order_no_ticketId():

Original file line number	Diff line number	Diff line change
`@@ -1613,4 +1613,4 @@ function merge_text_nodes( jsonml ) {`
`1613`	`1613`	`else {`
`1614`	`1614`	`return exports;`
`1615`	`1615`	`}`
`1616`		`-} )() );`
	`1616`	`+} )() );`