Skip to content

Commit 38ec445

Browse files
committed
Make if condition on boolean more readable
1 parent 4b70b2d commit 38ec445

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

junction/proposals/comments_views.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def create_proposal_comment(request, conference_slug, proposal_slug):
2727
Proposal, slug=proposal_slug, conference=conference)
2828
form = ProposalCommentForm(request.POST)
2929

30-
if request.user.is_active == False:
30+
if request.user.is_active is False:
3131
raise PermissionDenied()
3232

3333
if form.is_valid():
@@ -69,7 +69,7 @@ def create_proposal_comment(request, conference_slug, proposal_slug):
6969
@login_required
7070
@require_http_methods(['POST'])
7171
def mark_comment_as_spam(request, conference_slug, proposal_slug, proposal_comment_id):
72-
if not request.is_ajax() or request.user.is_active == False:
72+
if not request.is_ajax() or request.user.is_active is False:
7373
return HttpResponseForbidden()
7474

7575
conference = get_object_or_404(Conference, slug=conference_slug)
@@ -94,7 +94,7 @@ def mark_comment_as_spam(request, conference_slug, proposal_slug, proposal_comme
9494
@login_required
9595
@require_http_methods(['POST'])
9696
def unmark_comment_as_spam(request, conference_slug, proposal_slug, proposal_comment_id):
97-
if not request.is_ajax() or request.user.is_active == False:
97+
if not request.is_ajax() or request.user.is_active is False:
9898
return HttpResponseForbidden()
9999

100100
conference = get_object_or_404(Conference, slug=conference_slug)

junction/proposals/services.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,14 +158,14 @@ def send_mail_for_proposal_content(conference_id, proposal_id, host):
158158

159159

160160
def user_action_for_spam(user, threshold):
161-
"""When a comment is mark as spam, make appropriate status update to user model
161+
"""When a comment is marked as spam, make appropriate status update to user model
162162
"""
163163
total_spam = ProposalComment.objects.filter(commenter=user, is_spam=True).count()
164164
if total_spam >= threshold:
165-
if user.is_active != False:
165+
if user.is_active is True:
166166
user.is_active = False
167167
user.save()
168168
else:
169-
if user.is_active != True:
169+
if user.is_active is False:
170170
user.is_active = True
171171
user.save()

0 commit comments

Comments
 (0)