Fix on_delete deprecation warnings

Author: sks444

junction/base/models.py

@@ -1,14 +1,14 @@
 # -*- coding: utf-8 -*-
 from __future__ import absolute_import, unicode_literals
 
+# Third Party Stuff
 from django.contrib.auth.models import User
 from django.db import models
 
 
 class TimeAuditModel(models.Model):
     """To track when the record was created and last modified
     """
-
     created_at = models.DateTimeField(auto_now_add=True, verbose_name="Created At")
     modified_at = models.DateTimeField(auto_now=True, verbose_name="Last Modified At")
 
@@ -19,26 +19,22 @@ class Meta:
 class UserAuditModel(models.Model):
     """ To track who created and last modified the record
     """
-
     created_by = models.ForeignKey(
-        User,
-        related_name="created_%(class)s_set",
-        null=True,
-        blank=True,
-        verbose_name="Created By",
+        User, related_name='created_%(class)s_set',
+        null=True, blank=True, verbose_name="Created By",
+        on_delete=models.SET_NULL
     )
     modified_by = models.ForeignKey(
-        User,
-        related_name="updated_%(class)s_set",
-        null=True,
-        blank=True,
-        verbose_name="Modified By",
+        User, related_name='updated_%(class)s_set',
+        null=True, blank=True, verbose_name="Modified By",
+        on_delete=models.SET_NULL
     )
 
     class Meta:
         abstract = True
 
 
 class AuditModel(TimeAuditModel, UserAuditModel):
+
     class Meta:
         abstract = True

junction/conferences/migrations/0015_auto_20200322_1904.py

@@ -0,0 +1,82 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.9 on 2020-03-22 13:34
+from __future__ import unicode_literals
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('conferences', '0014_conferencesettings'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='conference',
+            name='created_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='created_conference_set', to=settings.AUTH_USER_MODEL, verbose_name='Created By'),
+        ),
+        migrations.AlterField(
+            model_name='conference',
+            name='modified_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='updated_conference_set', to=settings.AUTH_USER_MODEL, verbose_name='Modified By'),
+        ),
+        migrations.AlterField(
+            model_name='conference',
+            name='venue',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, to='conferences.ConferenceVenue'),
+        ),
+        migrations.AlterField(
+            model_name='conferencemoderator',
+            name='created_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='created_conferencemoderator_set', to=settings.AUTH_USER_MODEL, verbose_name='Created By'),
+        ),
+        migrations.AlterField(
+            model_name='conferencemoderator',
+            name='modified_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='updated_conferencemoderator_set', to=settings.AUTH_USER_MODEL, verbose_name='Modified By'),
+        ),
+        migrations.AlterField(
+            model_name='conferenceproposalreviewer',
+            name='created_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='created_conferenceproposalreviewer_set', to=settings.AUTH_USER_MODEL, verbose_name='Created By'),
+        ),
+        migrations.AlterField(
+            model_name='conferenceproposalreviewer',
+            name='modified_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='updated_conferenceproposalreviewer_set', to=settings.AUTH_USER_MODEL, verbose_name='Modified By'),
+        ),
+        migrations.AlterField(
+            model_name='conferencesetting',
+            name='created_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='created_conferencesetting_set', to=settings.AUTH_USER_MODEL, verbose_name='Created By'),
+        ),
+        migrations.AlterField(
+            model_name='conferencesetting',
+            name='modified_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='updated_conferencesetting_set', to=settings.AUTH_USER_MODEL, verbose_name='Modified By'),
+        ),
+        migrations.AlterField(
+            model_name='conferencevenue',
+            name='created_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='created_conferencevenue_set', to=settings.AUTH_USER_MODEL, verbose_name='Created By'),
+        ),
+        migrations.AlterField(
+            model_name='conferencevenue',
+            name='modified_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='updated_conferencevenue_set', to=settings.AUTH_USER_MODEL, verbose_name='Modified By'),
+        ),
+        migrations.AlterField(
+            model_name='room',
+            name='created_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='created_room_set', to=settings.AUTH_USER_MODEL, verbose_name='Created By'),
+        ),
+        migrations.AlterField(
+            model_name='room',
+            name='modified_by',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='updated_room_set', to=settings.AUTH_USER_MODEL, verbose_name='Modified By'),
+        ),
+    ]

junction/conferences/models.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 from __future__ import absolute_import, unicode_literals
 
+# Third Party Stuff
 from django.contrib.auth.models import User
 from django.core.exceptions import ValidationError
 from django.core.urlresolvers import reverse
@@ -13,109 +14,87 @@
 from slugify import slugify
 from uuid_upload_path import upload_to
 
+# Junction Stuff
+from junction.base.utils import get_date_diff_display
 from junction.base.constants import ConferenceSettingConstants, ConferenceStatus
 from junction.base.models import AuditModel
-from junction.base.utils import get_date_diff_display
 
 
 @python_2_unicode_compatible
 class Conference(AuditModel):
 
     """ Conference/Event master """
-
     name = models.CharField(max_length=255, verbose_name="Conference Name")
-    slug = AutoSlugField(
-        max_length=255, unique=True, populate_from=("name",), editable=True
-    )
+    slug = AutoSlugField(max_length=255, unique=True, populate_from=('name',),
+                         editable=True)
     description = models.TextField(default="")
     start_date = models.DateField(verbose_name="Start Date")
     end_date = models.DateField(verbose_name="End Date")
     logo = models.ImageField(blank=True, null=True, upload_to=upload_to)
     status = models.PositiveSmallIntegerField(
-        choices=ConferenceStatus.CHOICES, verbose_name="Current Status"
-    )
-    venue = models.ForeignKey("ConferenceVenue", null=True, blank=True)
-
-    twitter_id = models.CharField(
-        max_length=100,
-        blank=True,
-        null=True,
-        default="",
-        help_text=_("Used in social share widgets."),
-    )
-    hashtags = models.CharField(
-        max_length=100,
-        blank=True,
-        null=True,
-        default="",
-        help_text=_(
-            "Used in social sharing, use commas to separate to tags, no '#' required."
-        ),
+        choices=ConferenceStatus.CHOICES, verbose_name="Current Status")
+    venue = models.ForeignKey(
+        'ConferenceVenue', null=True, blank=True,
+        on_delete=models.SET_NULL
     )
 
+    twitter_id = models.CharField(max_length=100, blank=True, null=True, default='',
+                                  help_text=_('Used in social share widgets.'))
+    hashtags = models.CharField(max_length=100, blank=True, null=True, default='',
+                                help_text=_("Used in social sharing, use commas to separate to tags, no '#' required."))
+
     deleted = models.BooleanField(default=False, verbose_name="Is Deleted?")
 
     class Meta:
-        verbose_name = _("Conference")
-        verbose_name_plural = _("Conferences")
-        ordering = (
-            "-start_date",
-            "name",
-        )
-        get_latest_by = "start_date"
+        verbose_name = _('Conference')
+        verbose_name_plural = _('Conferences')
+        ordering = ('-start_date', 'name',)
+        get_latest_by = 'start_date'
 
     def __str__(self):
         return self.name
 
     def get_absolute_url(self):
-        return reverse("conference-detail", kwargs={"conference_slug": self.slug})
+        return reverse("conference-detail", kwargs={'conference_slug':
+                                                    self.slug})
 
     def duration_display(self):
         return get_date_diff_display(self.start_date, self.end_date)
 
     def clean(self):
         if self.end_date < self.start_date:
             msg = _("End date should be greater than start date.")
-            raise ValidationError({"end_date": msg})
+            raise ValidationError({'end_date': msg})
 
     def save(self, *args, **kwargs):
         if not self.slug:
             self.slug = slugify(self.name)
         if not self.pk:
             super(Conference, self).save(*args, **kwargs)
             public_voting = ConferenceSettingConstants.ALLOW_PUBLIC_VOTING_ON_PROPOSALS
-            ConferenceSetting.objects.create(
-                name=public_voting["name"],
-                value=public_voting["value"],
-                description=public_voting["description"],
-                conference=self,
-            )
+            ConferenceSetting.objects.create(name=public_voting['name'],
+                                             value=public_voting['value'],
+                                             description=public_voting['description'],
+                                             conference=self)
             display_propsals = ConferenceSettingConstants.DISPLAY_PROPOSALS_IN_PUBLIC
+            ConferenceSetting.objects.create(name=display_propsals['name'],
+                                             value=display_propsals['value'],
+                                             description=display_propsals['description'],
+                                             conference=self)
+            allow_plus_zero_vote = ConferenceSettingConstants.ALLOW_PLUS_ZERO_REVIEWER_VOTE
             ConferenceSetting.objects.create(
-                name=display_propsals["name"],
-                value=display_propsals["value"],
-                description=display_propsals["description"],
-                conference=self,
-            )
-            allow_plus_zero_vote = (
-                ConferenceSettingConstants.ALLOW_PLUS_ZERO_REVIEWER_VOTE
-            )
-            ConferenceSetting.objects.create(
-                name=allow_plus_zero_vote["name"],
-                value=allow_plus_zero_vote["value"],
-                description=allow_plus_zero_vote["description"],
-                conference=self,
-            )
+                name=allow_plus_zero_vote['name'],
+                value=allow_plus_zero_vote['value'],
+                description=allow_plus_zero_vote['description'],
+                conference=self)
             return
         super(Conference, self).save(*args, **kwargs)
 
     def is_accepting_proposals(self):
         """Check if any one of the proposal section is accepting proposal.
         """
-        if (
-            self.status == ConferenceStatus.CLOSED_CFP
-            or self.status == ConferenceStatus.SCHEDULE_PUBLISHED
-        ):
+        if (self.status == ConferenceStatus.CLOSED_CFP or
+                self.status == ConferenceStatus.SCHEDULE_PUBLISHED):
             return False
         return self.proposal_types.filter(end_date__gt=now()).exists()
 
@@ -124,15 +103,17 @@ def is_accepting_proposals(self):
 class ConferenceModerator(AuditModel):
 
     """ List of Conference Moderators/Administrators  """
-
-    conference = models.ForeignKey(Conference, related_name="moderators")
-    moderator = models.ForeignKey(User)
+    conference = models.ForeignKey(
+        Conference, related_name='moderators',
+        on_delete=models.CASCADE
+    )
+    moderator = models.ForeignKey(User, on_delete=models.CASCADE)
     active = models.BooleanField(default=True, verbose_name="Is Active?")
 
     class Meta:
         unique_together = ("conference", "moderator")
-        verbose_name = "moderator"
-        verbose_name_plural = "moderators"
+        verbose_name = 'moderator'
+        verbose_name_plural = 'moderators'
 
     def __str__(self):
         return "{}[{}]".format(self.moderator.get_full_name(), self.conference)
@@ -142,18 +123,20 @@ def __str__(self):
 class ConferenceProposalReviewer(AuditModel):
 
     """ List of global proposal reviewers """
-
-    conference = models.ForeignKey(Conference, related_name="proposal_reviewers")
-    reviewer = models.ForeignKey(User)
-    active = models.BooleanField(default=True, verbose_name="Is Active?")
-    nick = models.CharField(
-        max_length=255, verbose_name="Nick Name", default="Reviewer"
+    conference = models.ForeignKey(
+        Conference,
+        related_name='proposal_reviewers',
+        on_delete=models.CASCADE
     )
+    reviewer = models.ForeignKey(User, on_delete=models.CASCADE)
+    active = models.BooleanField(default=True, verbose_name="Is Active?")
+    nick = models.CharField(max_length=255, verbose_name="Nick Name",
+                            default="Reviewer")
     history = HistoricalRecords()
 
     class Meta:
-        verbose_name = "proposals reviewer"
-        verbose_name_plural = "proposals reviewers"
+        verbose_name = 'proposals reviewer'
+        verbose_name_plural = 'proposals reviewers'
         unique_together = ("conference", "reviewer")
 
     def __str__(self):
@@ -175,7 +158,7 @@ def __str__(self):
 
 class Room(AuditModel):
     name = models.CharField(max_length=100)
-    venue = models.ForeignKey(ConferenceVenue)
+    venue = models.ForeignKey(ConferenceVenue, on_delete=models.CASCADE)
 
     note = models.CharField(max_length=255)
 
@@ -185,7 +168,7 @@ def __str__(self):
 
 @python_2_unicode_compatible
 class ConferenceSetting(AuditModel):
-    conference = models.ForeignKey(Conference)
+    conference = models.ForeignKey(Conference, on_delete=models.CASCADE)
     name = models.CharField(max_length=100, db_index=True)
     value = models.BooleanField(default=False)
     description = models.CharField(max_length=255)