Sort all proposals when sorting by total votes

Author: ChillarAnand

junction/proposals/dashboard.py

@@ -247,21 +247,22 @@ def reviewer_votes_dashboard(request, conference_slug):
     elif votes == ProposalVotesFilter.MIN_ONE_VOTE:
         proposals_qs = [
             p for p in proposals_qs if p.get_reviewer_votes_count() >= votes]
-    elif votes == ProposalVotesFilter.SORT_BY_SUM:
-        proposals_qs = sorted(
-            proposals_qs, key=lambda x: x.get_reviewer_votes_sum(),
-            reverse=True)
     elif votes == ProposalVotesFilter.SORT_BY_REVIEWER:
         proposals_qs = sorted(
             proposals_qs,
             key=lambda x: x.get_reviewer_vote_value(reviewer=request.user),
             reverse=True,
         )
+    elif votes == ProposalVotesFilter.SORT_BY_SUM:
+        proposals_qs = sorted(
+            proposals_qs, key=lambda x: x.get_reviewer_votes_sum(),
+            reverse=True)
+        proposals = [s_items('', proposals_qs)]
 
-    for section in proposal_sections:
-        section_proposals = [
-            p for p in proposals_qs if p.proposal_section == section]
-        proposals.append(s_items(section, section_proposals))
+    if votes != ProposalVotesFilter.SORT_BY_SUM:
+        for section in proposal_sections:
+            section_proposals = [p for p in proposals_qs if p.proposal_section == section]
+            proposals.append(s_items(section, section_proposals))
 
     return render(request, 'proposals/votes-dashboard.html',
                   {'conference': conference,

junction/templates/proposals/votes-dashboard.html

@@ -41,6 +41,7 @@ <h2>Proposal Votes Dashboard</h2>
                 </form>
             </div>
             <br />
+            <hr>
             <div id="#proposals" class="row">
                 {% for section_items in proposals  %}
                     {% if section_items.proposals %}