tests

Author: marcoacierno

backend/api/schedule/tests/test_unassigned_schedule_items.py

@@ -14,7 +14,7 @@ def _unassigned_schedule_items(client, **input):
             id
         }
     }""",
-        variables={**input},
+        variables=input,
     )
 
 

backend/api/visa/mutations.py

@@ -1,4 +1,3 @@
-import json
 from api.context import Context
 from custom_admin.audit import create_change_admin_log_entry
 from visa.models import InvitationLetterDocument as InvitationLetterDocumentModel
@@ -21,9 +20,6 @@ class UpdateInvitationLetterDocumentStructureInput:
     footer: str
     pages: list[UpdateInvitationLetterDocumentPageInput]
 
-    def to_json(self) -> str:
-        return json.dumps(self.to_dict())
-
 
 @strawberry.input
 class UpdateInvitationLetterDocumentInput:
@@ -35,7 +31,16 @@ class UpdateInvitationLetterDocumentInput:
 def update_invitation_letter_document(
     info: strawberry.Info[Context], input: UpdateInvitationLetterDocumentInput
 ) -> InvitationLetterDocument:
-    invitation_letter_document = InvitationLetterDocumentModel.objects.get(id=input.id)
+    invitation_letter_document = InvitationLetterDocumentModel.objects.filter(
+        id=input.id
+    ).first()
+
+    if not invitation_letter_document:
+        raise ValueError("Invitation letter document not found")
+
+    if invitation_letter_document.document:
+        raise ValueError("Invitation letter document has a file attached")
+
     invitation_letter_document.dynamic_document = strawberry.asdict(
         input.dynamic_document
     )

backend/api/visa/permissions.py

@@ -25,7 +25,7 @@ def get_invitation_letter_document(self, kwargs):
 
 
 class CanEditInvitationLetterDocument(CanViewInvitationLetterDocument):
-    message = "Cannot view invitation letter document"
+    message = "Cannot edit invitation letter document"
 
     def has_permission(self, source, info, **kwargs):
         if not super().has_permission(source, info, **kwargs):

backend/api/visa/queries.py

@@ -7,8 +7,12 @@
 
 @strawberry.field(permission_classes=[CanViewInvitationLetterDocument])
 def invitation_letter_document(id: strawberry.ID) -> InvitationLetterDocument | None:
-    invitation_letter_document = InvitationLetterDocumentModel.objects.get(id=id)
-    return InvitationLetterDocument.from_model(invitation_letter_document)
+    if invitation_letter_document := InvitationLetterDocumentModel.objects.filter(
+        id=id
+    ).first():
+        return InvitationLetterDocument.from_model(invitation_letter_document)
+
+    return None
 
 
 VisaQuery = create_type(