Add tests for internal notes update in grants recap

Add two tests to verify the internal notes functionality:
- test_save_review_grants_updates_internal_notes: Tests that notes can
  be added, updated, and cleared
- test_save_review_grants_does_not_update_unchanged_internal_notes:
  Tests that unchanged notes don't trigger unnecessary DB writes

Co-authored-by: Ester Beltrami <[email protected]>

Author: github-actions[bot]

backend/reviews/tests/test_admin.py

@@ -723,3 +723,105 @@ def test_save_review_grants_two_times_does_not_create_duplicate_log_entries(rf,
         object_id=grant_1.id,
         change_message="[Review Session] Pending status changed from 'None' to 'approved'.",
     ).exists()
+
+
+def test_save_review_grants_updates_internal_notes(rf, mocker):
+    mocker.patch("reviews.admin.messages")
+
+    user = UserFactory(is_staff=True, is_superuser=True)
+    conference = ConferenceFactory()
+
+    # Create review session for grants
+    review_session = ReviewSessionFactory(
+        conference=conference,
+        session_type=ReviewSession.SessionType.GRANTS,
+        status=ReviewSession.Status.COMPLETED,
+    )
+    AvailableScoreOptionFactory(review_session=review_session, numeric_value=0)
+    AvailableScoreOptionFactory(review_session=review_session, numeric_value=1)
+
+    # Create grants with different initial internal_notes
+    grant_1 = GrantFactory(
+        conference=conference, status=Grant.Status.pending, internal_notes=""
+    )
+    grant_2 = GrantFactory(
+        conference=conference,
+        status=Grant.Status.pending,
+        internal_notes="Existing notes",
+    )
+    grant_3 = GrantFactory(
+        conference=conference,
+        status=Grant.Status.pending,
+        internal_notes="Notes to clear",
+    )
+
+    # Build POST data with notes updates
+    post_data = {
+        f"decision-{grant_1.id}": Grant.Status.pending,
+        f"notes-{grant_1.id}": "New notes for grant 1",
+        f"decision-{grant_2.id}": Grant.Status.pending,
+        f"notes-{grant_2.id}": "Updated notes for grant 2",
+        f"decision-{grant_3.id}": Grant.Status.pending,
+        f"notes-{grant_3.id}": "",  # Clear notes
+    }
+
+    request = rf.post("/", data=post_data)
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    response = admin._review_grants_recap_view(request, review_session)
+
+    # Should redirect after successful save
+    assert response.status_code == 302
+
+    # Refresh grants from database
+    grant_1.refresh_from_db()
+    grant_2.refresh_from_db()
+    grant_3.refresh_from_db()
+
+    # Verify internal notes were updated
+    assert grant_1.internal_notes == "New notes for grant 1"
+    assert grant_2.internal_notes == "Updated notes for grant 2"
+    assert grant_3.internal_notes == ""
+
+
+def test_save_review_grants_does_not_update_unchanged_internal_notes(rf, mocker):
+    mocker.patch("reviews.admin.messages")
+
+    user = UserFactory(is_staff=True, is_superuser=True)
+    conference = ConferenceFactory()
+
+    # Create review session for grants
+    review_session = ReviewSessionFactory(
+        conference=conference,
+        session_type=ReviewSession.SessionType.GRANTS,
+        status=ReviewSession.Status.COMPLETED,
+    )
+    AvailableScoreOptionFactory(review_session=review_session, numeric_value=0)
+    AvailableScoreOptionFactory(review_session=review_session, numeric_value=1)
+
+    # Create grant with existing notes
+    grant_1 = GrantFactory(
+        conference=conference,
+        status=Grant.Status.pending,
+        internal_notes="Existing notes",
+    )
+
+    # Submit the same notes (no change)
+    post_data = {
+        f"decision-{grant_1.id}": Grant.Status.pending,
+        f"notes-{grant_1.id}": "Existing notes",
+    }
+
+    request = rf.post("/", data=post_data)
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    response = admin._review_grants_recap_view(request, review_session)
+
+    assert response.status_code == 302
+
+    grant_1.refresh_from_db()
+
+    # Notes should remain unchanged
+    assert grant_1.internal_notes == "Existing notes"