Skip to content

Commit 76288df

Browse files
Rename max_proposals to max_proposals_per_user and expose in admin
- Renamed field from max_proposals to max_proposals_per_user for clarity - Updated migration to use new field name - Updated API mutations to reference new field name - Updated tests to use new field name - Exposed field in Conference admin under Conference fieldset Co-authored-by: Marco Acierno <[email protected]>
1 parent 051eef2 commit 76288df

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

backend/api/submissions/mutations.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -412,17 +412,17 @@ def send_submission(
412412
if not conference.is_cfp_open:
413413
errors.add_error("non_field_errors", "The call for paper is not open!")
414414

415-
if conference.max_proposals is not None:
415+
if conference.max_proposals_per_user is not None:
416416
user_submissions_count = (
417417
SubmissionModel.objects.of_user(request.user)
418418
.for_conference(conference)
419419
.non_cancelled()
420420
.count()
421421
)
422-
if user_submissions_count >= conference.max_proposals:
422+
if user_submissions_count >= conference.max_proposals_per_user:
423423
errors.add_error(
424424
"non_field_errors",
425-
f"You can only submit up to {conference.max_proposals} proposals",
425+
f"You can only submit up to {conference.max_proposals_per_user} proposals",
426426
)
427427

428428
if errors.has_errors:

backend/api/submissions/tests/test_send_submission.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,7 +1249,7 @@ def test_cannot_submit_more_than_3_proposals(graphql_client, user):
12491249
active_cfp=True,
12501250
durations=("50",),
12511251
audience_levels=("Beginner",),
1252-
max_proposals=3,
1252+
max_proposals_per_user=3,
12531253
)
12541254

12551255
SubmissionFactory(
@@ -1286,7 +1286,7 @@ def test_can_submit_unlimited_proposals_when_max_proposals_is_none(graphql_clien
12861286
active_cfp=True,
12871287
durations=("50",),
12881288
audience_levels=("Beginner",),
1289-
max_proposals=None, # No limit
1289+
max_proposals_per_user=None, # No limit
12901290
)
12911291

12921292
EmailTemplateFactory(

backend/conferences/admin/conference.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ class ConferenceAdmin(
181181
"audience_levels",
182182
"languages",
183183
"proposal_tags",
184+
"max_proposals_per_user",
184185
)
185186
},
186187
),

backend/conferences/migrations/0056_conference_max_proposals.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class Migration(migrations.Migration):
1212
operations = [
1313
migrations.AddField(
1414
model_name='conference',
15-
name='max_proposals',
15+
name='max_proposals_per_user',
1616
field=models.PositiveIntegerField(blank=True, help_text='Maximum number of proposals a user can submit. Leave empty for no limit.', null=True, verbose_name='max proposals per user'),
1717
),
1818
]

backend/conferences/models/conference.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ class Conference(GeoLocalizedModel, TimeFramedModel, TimeStampedModel):
117117
max_length=32224,
118118
)
119119

120-
max_proposals = models.PositiveIntegerField(
120+
max_proposals_per_user = models.PositiveIntegerField(
121121
_("max proposals per user"),
122122
null=True,
123123
blank=True,

0 commit comments

Comments
 (0)