Run migrations in a ECS container (#4171)

Author: marcoacierno

.github/workflows/deploy.yml

@@ -306,11 +306,6 @@ jobs:
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           AWS_DEFAULT_REGION: eu-central-1
 
-  # TODO Temporary workaround the fact that the lambda takes a bit to update
-  # so to avoid calling the old deployment, we want 20 seconds
-  # the 20 seconds is not a meaningful value, it is a random delay
-  # it might or might not be enough. This is just an hack until we add a solution for this
-  # e.g lambda versions?
   wait-aws-update:
     runs-on: ubuntu-latest
     needs: [terraform]
@@ -330,24 +325,6 @@ jobs:
           done
         shell: bash
 
-  # Migrate the database
-  migrate-pycon-backend-db:
-    runs-on: ubuntu-latest
-    needs: [terraform, wait-aws-update]
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.ref }}
-      - name: Migrate PyCon Backend DB
-        run: |
-          aws lambda invoke --function-name ${{ env.TF_WORKSPACE }}-pycon-backend --cli-binary-format raw-in-base64-out --payload '{ "_serverless-wsgi": { "command": "manage", "data": "migrate" } }' response.json
-          cat response.json
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
-
   deploy-fe:
     runs-on: ubuntu-latest
     needs: [migrate-pycon-backend-db]

infrastructure/applications/pycon_backend/worker.tf

@@ -281,6 +281,50 @@ resource "aws_ecs_task_definition" "worker" {
         interval = 10
       }
 
+      stopTimeout = 300
+    },
+    {
+      name              = "migrations"
+      image             = "${data.aws_ecr_repository.be_repo.repository_url}@${data.aws_ecr_image.be_arm_image.image_digest}"
+      memoryReservation = 200
+      essential         = false
+      entrypoint = [
+        "/home/app/.venv/bin/python",
+      ]
+
+      command = [
+        "manage.py", "migrate"
+      ]
+
+      environment = local.env_vars
+
+      mountPoints = []
+      systemControls = [
+        {
+          "namespace" : "net.core.somaxconn",
+          "value" : "4096"
+        }
+      ]
+
+      logConfiguration = {
+        logDriver = "awslogs"
+        options = {
+          "awslogs-group"         = var.logs_group_name
+          "awslogs-region"        = "eu-central-1"
+          "awslogs-stream-prefix" = "backend-migrations"
+        }
+      }
+
+      healthCheck = {
+        retries = 3
+        command = [
+          "CMD-SHELL",
+          "echo 1"
+        ]
+        timeout  = 3
+        interval = 10
+      }
+
       stopTimeout = 300
     }
   ])