tests

Author: marcoacierno

backend/visa/admin.py

@@ -20,11 +20,6 @@
 )
 
 
-def process_invitation_letters(modeladmin, request, queryset):
-    for invitation_letter_request in queryset:
-        invitation_letter_request.schedule()
-
-
 @admin.register(InvitationLetterRequest)
 class InvitationLetterRequestAdmin(admin.ModelAdmin):
     fields = (
@@ -76,7 +71,6 @@ class InvitationLetterRequestAdmin(admin.ModelAdmin):
         "has_accommodation_via_grant",
         "send_via_email",
     )
-    actions = [process_invitation_letters]
 
     def save_form(self, request, form, change):
         obj = super().save_form(request, form, change)

backend/visa/models.py

@@ -85,23 +85,21 @@ def email(self):
 
         return self.requester.email
 
-    @property
     def has_accommodation_via_grant(self):
         grant = self.user_grant
 
         if not grant:
             return False
 
-        return grant.has_approved_accommodation
+        return grant.has_approved_accommodation()
 
-    @property
     def has_travel_via_grant(self):
         grant = self.user_grant
 
         if not grant:
             return False
 
-        return grant.has_approved_travel
+        return grant.has_approved_travel()
 
     @property
     def grant_approved_type(self):
@@ -116,7 +114,7 @@ def grant_approved_type(self):
     def user_grant(self):
         return Grant.objects.for_conference(self.conference).of_user(self.user).first()
 
-    def role(self):
+    def get_role(self):
         user = self.user
 
         if not user:

backend/visa/tasks.py

@@ -140,10 +140,10 @@ def _render_content(content, invitation_letter_request, config):
                 "date_of_birth": invitation_letter_request.date_of_birth,
                 "passport_number": invitation_letter_request.passport_number,
                 "embassy_name": invitation_letter_request.embassy_name,
-                "role": invitation_letter_request.role,
+                "role": invitation_letter_request.get_role(),
                 "grant_approved_type": invitation_letter_request.grant_approved_type,
-                "has_accommodation_via_grant": invitation_letter_request.has_accommodation_via_grant,
-                "has_travel_via_grant": invitation_letter_request.has_travel_via_grant,
+                "has_accommodation_via_grant": invitation_letter_request.has_accommodation_via_grant(),
+                "has_travel_via_grant": invitation_letter_request.has_travel_via_grant(),
                 # conference
                 "conference": invitation_letter_request.conference,
             }
@@ -159,7 +159,7 @@ def download_pretix_ticket(invitation_letter_request):
     attendee_ticket = next(
         (ticket for ticket in attendee_tickets if ticket["item"]["admission"]), None
     )
-    assert attendee_ticket
+    assert attendee_ticket, "No attendee ticket found"
 
     ticket_url = attendee_ticket["downloads"][0]["url"]
 

backend/visa/tests/test_admin.py

@@ -0,0 +1,104 @@
+from django.urls import reverse
+from django.contrib.admin.sites import AdminSite
+from visa.models import InvitationLetterOrganizerConfig, InvitationLetterRequest
+from visa.admin import InvitationLetterDocumentInline, InvitationLetterRequestAdmin
+import pytest
+
+from visa.tests.factories import (
+    InvitationLetterDocumentFactory,
+    InvitationLetterOrganizerConfigFactory,
+    InvitationLetterRequestFactory,
+)
+
+pytestmark = pytest.mark.django_db
+
+
+def test_edit_dynamic_document_view(rf, admin_user):
+    admin = InvitationLetterDocumentInline(
+        parent_model=InvitationLetterOrganizerConfig, admin_site=AdminSite()
+    )
+
+    config = InvitationLetterOrganizerConfigFactory()
+    document = InvitationLetterDocumentFactory(
+        invitation_letter_organizer_config=config,
+        document=None,
+    )
+
+    request = rf.get("/")
+    request.user = admin_user
+    response = admin.edit_dynamic_document_view(request, config.id, document.id)
+
+    assert response.status_code == 200
+    assert response.template_name == "astro/invitation-letter-document-builder.html"
+    assert response.context_data["arguments"]["document_id"] == document.id
+    assert response.context_data["arguments"]["breadcrumbs"]
+
+
+def test_edit_dynamic_document_button():
+    admin = InvitationLetterDocumentInline(
+        parent_model=InvitationLetterOrganizerConfig, admin_site=AdminSite()
+    )
+
+    config = InvitationLetterOrganizerConfigFactory()
+    document = InvitationLetterDocumentFactory(
+        invitation_letter_organizer_config=config,
+        document=None,
+    )
+
+    html = admin.edit_dynamic_document(document)
+
+    url = reverse(
+        "admin:edit_dynamic_document",
+        kwargs={
+            "config_id": config.id,
+            "document_id": document.id,
+        },
+    )
+    assert html == f'<a href="{url}">Edit</a>'
+
+
+def test_edit_dynamic_document_button_is_empty_for_static_docs():
+    admin = InvitationLetterDocumentInline(
+        parent_model=InvitationLetterOrganizerConfig, admin_site=AdminSite()
+    )
+
+    config = InvitationLetterOrganizerConfigFactory()
+    document = InvitationLetterDocumentFactory(
+        invitation_letter_organizer_config=config
+    )
+
+    html = admin.edit_dynamic_document(document)
+
+    assert html == ""
+
+
+def test_invitation_letter_request_admin():
+    admin = InvitationLetterRequestAdmin(
+        model=InvitationLetterRequest, admin_site=AdminSite()
+    )
+
+    invitation_letter_request = InvitationLetterRequestFactory()
+
+    assert 'name="_process_now"' in admin.process_now(invitation_letter_request)
+    assert "Generate the invitation letter first" == admin.send_via_email(
+        invitation_letter_request
+    )
+
+
+def test_invitation_letter_request_admin_post_processing_redirects_to_changelist(
+    rf, admin_user
+):
+    admin = InvitationLetterRequestAdmin(
+        model=InvitationLetterRequest, admin_site=AdminSite()
+    )
+
+    invitation_letter_request = InvitationLetterRequestFactory()
+    request = rf.post("/")
+    request.user = admin_user
+    request.POST = {"_process_now": "1"}
+    response = admin.response_post_save_change(request, invitation_letter_request)
+
+    assert response.status_code == 302
+    assert response.url == reverse(
+        "admin:visa_invitationletterrequest_change", args=[invitation_letter_request.id]
+    )

backend/visa/tests/test_models.py

@@ -0,0 +1,89 @@
+from submissions.models import Submission
+from submissions.tests.factories import SubmissionFactory
+from grants.models import Grant
+from grants.tests.factories import GrantFactory
+from users.tests.factories import UserFactory
+from visa.models import InvitationLetterRequestOnBehalfOf
+from visa.tests.factories import InvitationLetterRequestFactory
+import pytest
+
+pytestmark = pytest.mark.django_db
+
+
+def test_request_on_behalf_of_other():
+    request = InvitationLetterRequestFactory(
+        on_behalf_of=InvitationLetterRequestOnBehalfOf.OTHER,
+        email_address="[email protected]",
+    )
+
+    assert request.on_behalf_of_other
+    assert request.email == "[email protected]"
+    assert request.user is None
+    assert request.get_role() == "Attendee"
+
+    # With matching user, it is found
+    user = UserFactory(email="[email protected]")
+    assert request.user.id == user.id
+
+
+@pytest.mark.parametrize(
+    "approved_type",
+    [
+        Grant.ApprovedType.ticket_accommodation,
+        Grant.ApprovedType.ticket_only,
+        Grant.ApprovedType.ticket_travel,
+        Grant.ApprovedType.ticket_travel_accommodation,
+    ],
+)
+def test_request_grant_info(approved_type):
+    request = InvitationLetterRequestFactory(
+        on_behalf_of=InvitationLetterRequestOnBehalfOf.SELF,
+        email_address="[email protected]",
+    )
+    grant = GrantFactory(
+        conference=request.conference,
+        user=request.requester,
+        approved_type=approved_type,
+    )
+
+    assert request.user_grant == grant
+    assert request.has_accommodation_via_grant() == (
+        approved_type
+        in [
+            Grant.ApprovedType.ticket_accommodation,
+            Grant.ApprovedType.ticket_travel_accommodation,
+        ]
+    )
+    assert request.has_travel_via_grant() == (
+        approved_type
+        in [
+            Grant.ApprovedType.ticket_travel,
+            Grant.ApprovedType.ticket_travel_accommodation,
+        ]
+    )
+    assert request.grant_approved_type == approved_type
+
+
+def test_role_for_speakers():
+    request = InvitationLetterRequestFactory(
+        on_behalf_of=InvitationLetterRequestOnBehalfOf.SELF,
+    )
+    SubmissionFactory(
+        speaker=request.requester,
+        conference=request.conference,
+        status=Submission.STATUS.accepted,
+    )
+
+    assert request.get_role() == "Speaker"
+
+
+def test_schedule_processing(django_capture_on_commit_callbacks, mocker):
+    mock_task = mocker.patch("visa.tasks.process_invitation_letter_request")
+    request = InvitationLetterRequestFactory(
+        on_behalf_of=InvitationLetterRequestOnBehalfOf.SELF,
+    )
+
+    with django_capture_on_commit_callbacks(execute=True):
+        request.schedule()
+
+    mock_task.delay.assert_called_once_with(invitation_letter_request_id=request.id)

backend/visa/tests/test_tasks.py

@@ -204,6 +204,22 @@ def test_process_invitation_letter_request_handles_failing_ticket_pdfs(
     )
 
 
+@override_settings(PRETIX_API="https://pretix/api/")
+def test_process_invitation_letter_request_does_nothing_for_processed_reqs():
+    conference = ConferenceFactory()
+    InvitationLetterOrganizerConfigFactory(organizer=conference.organizer)
+
+    request = InvitationLetterRequestFactory(
+        conference=conference,
+        status=InvitationLetterRequestStatus.PROCESSED,
+    )
+
+    process_invitation_letter_request(invitation_letter_request_id=request.id)
+
+    request.refresh_from_db()
+    assert request.status == InvitationLetterRequestStatus.PROCESSED
+
+
 def test_process_invitation_letter_request_failed():
     request = InvitationLetterRequestFactory()