Forbid update of title and abstract when CFP is closed

Author: estyxx

backend/api/submissions/mutations.py

@@ -263,6 +263,22 @@ class UpdateSubmissionInput(BaseSubmissionInput):
     def validate(self, conference: Conference, submission: SubmissionModel):
         errors = super().validate(conference)
 
+        # Check if CFP is closed and prevent editing of title and abstract
+        if not conference.is_cfp_open:
+            if LazyI18nString(self.title.to_dict()) != submission.title:
+                errors.add_error(
+                    "title",
+                    "You cannot edit the title after the call for proposals deadline has passed.",
+                )
+
+            if LazyI18nString(self.abstract.to_dict()) != submission.abstract:
+                print(LazyI18nString(self.abstract.to_dict()).data)
+                print(submission.abstract.data)
+                errors.add_error(
+                    "abstract",
+                    "You cannot edit the abstract after the call for proposals deadline has passed.",
+                )
+
         if self.materials:
             if len(self.materials) > 3:
                 errors.add_error(

backend/api/submissions/tests/test_edit_submission.py

@@ -1070,6 +1070,8 @@ def test_can_edit_submission_outside_cfp(graphql_client, user):
         new_duration=new_duration,
         new_type=new_type,
         new_languages=["en"],
+        new_title=submission.title.data,  # Keep title unchanged
+        new_abstract=submission.abstract.data,  # Keep abstract unchanged
     )
 
     assert response["data"]["updateSubmission"]["__typename"] == "Submission"
@@ -1301,3 +1303,85 @@ def test_update_submission_with_do_not_record_true(graphql_client, user):
 
     submission.refresh_from_db()
     assert submission.do_not_record is True
+
+
+def test_cannot_update_title_after_cfp_deadline(graphql_client, user):
+    conference = ConferenceFactory(
+        topics=("life", "diy"),
+        languages=("en",),
+        durations=("10", "20"),
+        active_cfp=False,  # CFP deadline is in the past
+        audience_levels=("adult", "senior"),
+        submission_types=("talk", "workshop"),
+    )
+
+    submission = SubmissionFactory(
+        speaker_id=user.id,
+        custom_topic="life",
+        custom_duration="10m",
+        custom_audience_level="adult",
+        custom_submission_type="talk",
+        languages=["en"],
+        tags=["python", "ml"],
+        conference=conference,
+    )
+
+    original_title = submission.title.localize("en")
+
+    graphql_client.force_login(user)
+
+    response = _update_submission(
+        graphql_client,
+        submission=submission,
+        new_title={"en": "Updated Title After Deadline"},
+    )
+
+    assert response["data"]["updateSubmission"]["__typename"] == "SendSubmissionErrors"
+    assert response["data"]["updateSubmission"]["errors"]["validationTitle"] == [
+        "You cannot edit the title after the call for proposals deadline has passed."
+    ]
+
+    # Verify the title was not updated
+    submission.refresh_from_db()
+    assert submission.title.localize("en") == original_title
+
+
+def test_cannot_update_abstract_after_cfp_deadline(graphql_client, user):
+    conference = ConferenceFactory(
+        topics=("life", "diy"),
+        languages=("en",),
+        durations=("10", "20"),
+        active_cfp=False,  # CFP deadline is in the past
+        audience_levels=("adult", "senior"),
+        submission_types=("talk", "workshop"),
+    )
+
+    submission = SubmissionFactory(
+        speaker_id=user.id,
+        custom_topic="life",
+        custom_duration="10m",
+        custom_audience_level="adult",
+        custom_submission_type="talk",
+        languages=["en"],
+        tags=["python", "ml"],
+        conference=conference,
+    )
+
+    original_abstract = submission.abstract.localize("en")
+
+    graphql_client.force_login(user)
+
+    response = _update_submission(
+        graphql_client,
+        submission=submission,
+        new_abstract={"en": "Updated abstract after deadline"},
+    )
+
+    assert response["data"]["updateSubmission"]["__typename"] == "SendSubmissionErrors"
+    assert response["data"]["updateSubmission"]["errors"]["validationAbstract"] == [
+        "You cannot edit the abstract after the call for proposals deadline has passed."
+    ]
+
+    # Verify the abstract was not updated
+    submission.refresh_from_db()
+    assert submission.abstract.localize("en") == original_abstract