Skip to content

Commit edfc50e

Browse files
committed
Fix issue when changing status
1 parent 6a859d7 commit edfc50e

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

backend/reviews/admin.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def go_to_review_screen(self, obj):
160160

161161
return mark_safe(
162162
f"""
163-
<a href="{reverse('admin:reviews-start', kwargs={'review_session_id': obj.id})}">
163+
<a href="{reverse("admin:reviews-start", kwargs={"review_session_id": obj.id})}">
164164
Go to review screen
165165
</a>
166166
"""
@@ -176,7 +176,7 @@ def go_to_recap_screen(self, obj):
176176

177177
return mark_safe(
178178
f"""
179-
<a href="{reverse('admin:reviews-recap', kwargs={'review_session_id': obj.id})}">
179+
<a href="{reverse("admin:reviews-recap", kwargs={"review_session_id": obj.id})}">
180180
Go to recap screen
181181
</a>
182182
"""
@@ -282,7 +282,11 @@ def _review_grants_recap_view(self, request, review_session):
282282

283283
approved_type = approved_type_decisions.get(grant.id, "")
284284

285-
grant.pending_status = decision
285+
if decision != grant.status:
286+
grant.pending_status = decision
287+
elif decision == grant.status:
288+
grant.pending_status = None
289+
286290
grant.approved_type = (
287291
approved_type if decision == Grant.Status.approved else None
288292
)
@@ -736,7 +740,7 @@ def _render_proposal_review(
736740
seen=request.GET.get("seen", "").split(","),
737741
existing_comment=existing_comment,
738742
review_session_repr=str(review_session),
739-
title=f'Proposal Review: {proposal.title.localize("en")}',
743+
title=f"Proposal Review: {proposal.title.localize('en')}",
740744
)
741745
return TemplateResponse(request, "proposal-review.html", context)
742746

0 commit comments

Comments
 (0)