cleanup tests

Author: marcoacierno

backend/api/visa/tests/queries/test_invitation_letter_document.py

@@ -1,5 +1,5 @@
 from django.contrib.auth.models import Permission
-from visa.tests.factories import InvitationLetterDocumentFactory
+from visa.tests.factories import InvitationLetterDynamicDocumentFactory
 import pytest
 
 pytestmark = pytest.mark.django_db
@@ -32,20 +32,7 @@ def _invitation_letter_document(client, **input):
 def test_query_invitation_letter_document(admin_superuser, admin_graphql_api_client):
     admin_graphql_api_client.force_login(admin_superuser)
 
-    document = InvitationLetterDocumentFactory(
-        document=None,
-        dynamic_document={
-            "header": {"content": "header"},
-            "footer": {"content": "footer"},
-            "pages": [
-                {
-                    "id": "id",
-                    "title": "title",
-                    "content": "content",
-                }
-            ],
-        },
-    )
+    document = InvitationLetterDynamicDocumentFactory()
     response = _invitation_letter_document(admin_graphql_api_client, id=document.id)
 
     assert response["data"]["invitationLetterDocument"]["id"] == str(document.id)
@@ -67,20 +54,7 @@ def test_query_non_existent_invitation_letter_document(
 ):
     admin_graphql_api_client.force_login(admin_superuser)
 
-    InvitationLetterDocumentFactory(
-        document=None,
-        dynamic_document={
-            "header": {"content": "header"},
-            "footer": {"content": "footer"},
-            "pages": [
-                {
-                    "id": "id",
-                    "title": "title",
-                    "content": "content",
-                }
-            ],
-        },
-    )
+    InvitationLetterDynamicDocumentFactory()
     response = _invitation_letter_document(admin_graphql_api_client, id=959)
     assert not response.get("errors")
     assert not response["data"]["invitationLetterDocument"]
@@ -91,20 +65,7 @@ def test_query_non_existent_invitation_letter_document_as_user(
 ):
     admin_graphql_api_client.force_login(user)
 
-    InvitationLetterDocumentFactory(
-        document=None,
-        dynamic_document={
-            "header": {"content": "header"},
-            "footer": {"content": "footer"},
-            "pages": [
-                {
-                    "id": "id",
-                    "title": "title",
-                    "content": "content",
-                }
-            ],
-        },
-    )
+    InvitationLetterDynamicDocumentFactory()
     response = _invitation_letter_document(admin_graphql_api_client, id=959)
     assert response["errors"][0]["message"] == "Cannot view invitation letter document"
     assert not response["data"]["invitationLetterDocument"]
@@ -115,20 +76,7 @@ def test_cannot_query_invitation_letter_document_as_user(
 ):
     admin_graphql_api_client.force_login(user)
 
-    document = InvitationLetterDocumentFactory(
-        document=None,
-        dynamic_document={
-            "header": {"content": "header"},
-            "footer": {"content": "footer"},
-            "pages": [
-                {
-                    "id": "id",
-                    "title": "title",
-                    "content": "content",
-                }
-            ],
-        },
-    )
+    document = InvitationLetterDynamicDocumentFactory()
     response = _invitation_letter_document(admin_graphql_api_client, id=document.id)
 
     assert response["errors"][0]["message"] == "Cannot view invitation letter document"
@@ -140,20 +88,7 @@ def test_cannot_query_invitation_letter_document_as_staff_without_permission(
 ):
     admin_graphql_api_client.force_login(admin_user)
 
-    document = InvitationLetterDocumentFactory(
-        document=None,
-        dynamic_document={
-            "header": {"content": "header"},
-            "footer": {"content": "footer"},
-            "pages": [
-                {
-                    "id": "id",
-                    "title": "title",
-                    "content": "content",
-                }
-            ],
-        },
-    )
+    document = InvitationLetterDynamicDocumentFactory()
 
     response = _invitation_letter_document(admin_graphql_api_client, id=document.id)
 
@@ -166,20 +101,7 @@ def test_query_invitation_letter_document_as_staff(
 ):
     admin_graphql_api_client.force_login(admin_user)
 
-    document = InvitationLetterDocumentFactory(
-        document=None,
-        dynamic_document={
-            "header": {"content": "header"},
-            "footer": {"content": "footer"},
-            "pages": [
-                {
-                    "id": "id",
-                    "title": "title",
-                    "content": "content",
-                }
-            ],
-        },
-    )
+    document = InvitationLetterDynamicDocumentFactory()
 
     admin_user.admin_all_conferences = True
     admin_user.save()