Add test

Author: estyxx

backend/api/grants/mutations.py

@@ -257,7 +257,7 @@ def send_grant(self, info: Info, input: SendGrantInput) -> SendGrantResult:
                 },
             )
 
-            send_grant_application_confirmation_email(instance)
+            send_grant_application_confirmation_email.delay(grant_id=instance.id)
 
         # hack because we return django models
         instance.__strawberry_definition__ = Grant.__strawberry_definition__

backend/api/grants/tests/test_send_grant.py

@@ -3,7 +3,9 @@
 from grants.tests.factories import GrantFactory
 import pytest
 from participants.models import Participant
+from grants.models import Grant
 
+from unittest.mock import call
 
 pytestmark = pytest.mark.django_db
 
@@ -84,7 +86,10 @@ def _send_grant(client, conference, conference_code=None, **kwargs):
     return response
 
 
-def test_send_grant(graphql_client, user):
+def test_send_grant(graphql_client, user, mocker):
+    mock_confirmation_email = mocker.patch(
+        "api.grants.mutations.send_grant_application_confirmation_email"
+    )
     graphql_client.force_login(user)
     conference = ConferenceFactory(active_grants=True)
 
@@ -95,13 +100,18 @@ def test_send_grant(graphql_client, user):
 
     participant = Participant.objects.get(conference=conference, user_id=user.id)
     assert participant.bio == "my bio"
-
+    grant = Grant.objects.get(id=response["data"]["sendGrant"]["id"])
+    assert grant.conference == conference
     assert PrivacyPolicyAcceptanceRecord.objects.filter(
         user=user, conference=conference, privacy_policy="grant"
     ).exists()
+    mock_confirmation_email.delay.assert_called_once_with(grant_id=grant.id)
 
 
-def test_cannot_send_a_grant_if_grants_are_closed(graphql_client, user):
+def test_cannot_send_a_grant_if_grants_are_closed(graphql_client, user, mocker):
+    mock_confirmation_email = mocker.patch(
+        "api.grants.mutations.send_grant_application_confirmation_email"
+    )
     graphql_client.force_login(user)
     conference = ConferenceFactory(active_grants=False)
 
@@ -112,6 +122,7 @@ def test_cannot_send_a_grant_if_grants_are_closed(graphql_client, user):
     assert response["data"]["sendGrant"]["errors"]["nonFieldErrors"] == [
         "The grants form is not open!"
     ]
+    mock_confirmation_email.delay.assert_not_called()
 
 
 def test_cannot_send_a_grant_if_grants_deadline_do_not_exists(graphql_client, user):
@@ -136,7 +147,10 @@ def test_cannot_send_a_grant_as_unlogged_user(graphql_client):
     assert resp["errors"][0]["message"] == "User not logged in"
 
 
-def test_cannot_send_two_grants_to_the_same_conference(graphql_client, user):
+def test_cannot_send_two_grants_to_the_same_conference(graphql_client, user, mocker):
+    mock_confirmation_email = mocker.patch(
+        "api.grants.mutations.send_grant_application_confirmation_email"
+    )
     graphql_client.force_login(user)
     conference = ConferenceFactory(active_grants=True)
     _send_grant(graphql_client, conference)
@@ -148,18 +162,29 @@ def test_cannot_send_two_grants_to_the_same_conference(graphql_client, user):
     assert response["data"]["sendGrant"]["errors"]["nonFieldErrors"] == [
         "Grant already submitted!"
     ]
+    mock_confirmation_email.delay.assert_called_once()
 
 
-def test_can_send_two_grants_to_different_conferences(graphql_client, user):
+def test_can_send_two_grants_to_different_conferences(graphql_client, user, mocker):
+    mock_confirmation_email = mocker.patch(
+        "api.grants.mutations.send_grant_application_confirmation_email"
+    )
     graphql_client.force_login(user)
     conference = ConferenceFactory(active_grants=True)
     conference_2 = ConferenceFactory(active_grants=True)
-    _send_grant(graphql_client, conference)
-
-    response = _send_grant(graphql_client, conference_2)
-
-    assert not response.get("errors")
-    assert response["data"]["sendGrant"]["__typename"] == "Grant"
+    first_response = _send_grant(graphql_client, conference)
+
+    second_response = _send_grant(graphql_client, conference_2)
+
+    assert not second_response.get("errors")
+    assert second_response["data"]["sendGrant"]["__typename"] == "Grant"
+    mock_confirmation_email.delay.assert_has_calls(
+        [
+            call(grant_id=int(first_response["data"]["sendGrant"]["id"])),
+            call(grant_id=int(second_response["data"]["sendGrant"]["id"])),
+        ],
+        any_order=True,
+    )
 
 
 def test_invalid_conference(graphql_client, user):

backend/grants/tasks.py

@@ -173,7 +173,9 @@ def _new_send_grant_email(
     grant.save()
 
 
-def send_grant_application_confirmation_email(grant: Grant):
+@app.task
+def send_grant_application_confirmation_email(*, grant_id):
+    grant = Grant.objects.get(id=grant_id)
     email_template = EmailTemplate.objects.for_conference(
         grant.conference
     ).get_by_identifier(EmailTemplateIdentifier.grant_application_confirmation)

backend/grants/tests/test_tasks.py

@@ -11,6 +11,7 @@
     send_grant_reply_approved_email,
     send_grant_reply_rejected_email,
     send_grant_reply_waiting_list_email,
+    send_grant_application_confirmation_email,
 )
 from grants.models import Grant
 
@@ -311,3 +312,23 @@ def test_send_grant_reply_waiting_list_update_email(settings):
             "reply_url": "https://pycon.it/grants/reply/",
         },
     )
+
+
+def test_send_grant_application_confirmation_email():
+    user = UserFactory(
+        full_name="Marco Acierno",
+        email="[email protected]",
+        name="Marco",
+        username="marco",
+    )
+    grant = GrantFactory(user=user)
+
+    with patch("grants.tasks.EmailTemplate") as mock_email_template:
+        send_grant_application_confirmation_email(grant_id=grant.id)
+
+    mock_email_template.objects.for_conference().get_by_identifier().send_email.assert_called_once_with(
+        recipient=user,
+        placeholders={
+            "user_name": "Marco Acierno",
+        },
+    )