Improve email template tests

[marcoacierno]

• We should assert the right template is being sent
• We shouldn't mock the whole EmailTemplate class. Maybe build a fixture like we had before sent_emails

[marcoacierno]

@claude work on this issue according to the description

[claude]

Claude finished @marcoacierno's task —— View job • claude/issue-4082-20250901-1621 • Create PR ➔

---

Email template test improvements completed! ✅

Todo List:

• Analyze current email template tests and identify issues
• Find existing email template code and testing patterns
• Look for previous sent_emails fixture implementation
• Implement improved test fixtures without mocking EmailTemplate class
• Add assertions to verify correct templates are being sent
• Run tests to validate improvements
• Run linting and formatting checks
• Commit and push changes

Summary of Improvements:

Key Changes Made:

1. Created sent_emails fixture (backend/conftest.py):

   • Provides access to SentEmail objects created during tests
   • Allows verification of actual email template usage without mocking

2. Improved Test Assertions:

   • ✅ Assert correct email template identifier is used
   • ✅ Assert email template belongs to correct conference
   • ✅ Assert email sent to correct recipient
   • ✅ Assert placeholders are processed correctly
   • ✅ Removed problematic EmailTemplate class mocking

3. Updated Test Files:

   • api/submissions/tests/test_send_submission.py - test_submit_talk()
   • submissions/tests/test_tasks.py - proposal rejection & waiting list tests
   • api/grants/tests/test_send_grant.py - grant application test

Benefits:

• Tests now verify the actual template identifier being used
• Tests verify real email creation via SentEmail records
• More robust testing without over-mocking
• Better alignment with the issue requirements

Commit: 71d1fdd - All changes pushed to claude/issue-4082-20250901-1621