When a grantee confirms his grant the Pending status is not updated

[estyxx]

I noticed a Confirmed grant with Pending status still in waiting list.

[marcoacierno]

@estyxx I wonder if trying to keep the pending_status field in sync is a mistake and instead by default we should have it set to None meaning that there isn't a new pending status (and we can assume pending==status) and if it is set to something, that's the pending state?

[marcoacierno]

@claude work on this issue by changing how pending_status works. Instead of trying to keep it in sync, we should assume that if pending_status is None, there isn't any pending change while if it is set, it means the grant new pending status is the one set in the variable

[claude]

Claude finished @marcoacierno's task —— View job • claude/issue-4408-20250727-1301 • Create PR ➔

---

✅ Fixed grant pending status sync issue

Todo List

• Read CLAUDE.md for repo-specific instructions (no CLAUDE.md found)
• Search for pending_status usage in the codebase
• Analyze current implementation logic
• Implement new logic (None = no pending change, set value = pending status)
• Update tests to reflect new behavior
• Commit and push changes
• Provide PR link

Implementation Summary

The issue was caused by problematic sync logic that tried to keep pending_status in sync with status. This caused confirmed grants to still show as pending in the waiting list.

Key changes made:

1. Grant model (/backend/grants/models.py):

   • Changed pending_status field to allow null=True (removed default)
   • Removed the sync logic: if self.pending_status == self._original_status: self.pending_status = self.status
   • Updated _calculate_grant_amounts to use effective status (pending_status if set, otherwise current status)

2. Admin interface (/backend/grants/admin.py):

   • Updated GrantConfirmPendingStatusProxyAdmin query to show only grants where pending_status is not null

3. Admin actions (/backend/custom_admin/admin.py):

   • Updated reset_pending_status_back_to_status to set pending_status=None

4. Tests (/backend/grants/tests/test_models.py):

   • Updated existing tests and added new tests for the new logic

New logic:

• pending_status = None → No pending change (use current status)
• pending_status = value → There's a pending status change

Note: A database migration will be needed to update the schema, but that requires additional permissions.

---