Merge pull request #485 from tacaswell/mnt_improve_warnings

MNT: improve warnings

Author: eriknw

toolz/compatibility.py

@@ -3,7 +3,7 @@
               "needed in Python 3 and has been deprecated. Please "
               "import these utilities directly from the standard library. "
               "This module will be removed in a future release.",
-              category=DeprecationWarning)
+              category=DeprecationWarning, stacklevel=2)
 
 import operator
 import sys

toolz/functoolz.py

@@ -5,9 +5,12 @@
 from importlib import import_module
 from textwrap import dedent
 from types import MethodType
+import sys
 
 from .utils import no_default
 
+PYPY = hasattr(sys, 'pypy_version_info') and sys.version_info[0] > 2
+
 
 __all__ = ('identity', 'apply', 'thread_first', 'thread_last', 'memoize',
            'compose', 'compose_left', 'pipe', 'complement', 'juxt', 'do',

toolz/tests/test_compatibility.py

@@ -1 +1,10 @@
-import toolz.compatibility
+
+import pytest
+import importlib
+
+def test_compat_warn():
+    with pytest.warns(DeprecationWarning):
+        # something else is importing this,
+        import toolz.compatibility
+        # reload to be sure we warn
+        importlib.reload(toolz.compatibility)

toolz/tests/test_itertoolz.py

@@ -542,8 +542,8 @@ def test_random_sample():
 
     assert rsample1 != rsample2
 
-    assert mk_rsample(object) == mk_rsample(object)
-    assert mk_rsample(object) != mk_rsample(object())
+    assert mk_rsample(hash(object)) == mk_rsample(hash(object))
+    assert mk_rsample(hash(object)) != mk_rsample(hash(object()))
     assert mk_rsample(b"a") == mk_rsample(u"a")
 
     assert raises(TypeError, lambda: mk_rsample([]))

versioneer.py

@@ -339,9 +339,9 @@ def get_config_from_root(root):
     # configparser.NoOptionError (if it lacks "VCS="). See the docstring at
     # the top of versioneer.py for instructions on writing your setup.cfg .
     setup_cfg = os.path.join(root, "setup.cfg")
-    parser = configparser.SafeConfigParser()
-    with open(setup_cfg, "r") as f:
-        parser.readfp(f)
+    parser = configparser.ConfigParser()
+
+    parser.read(setup_cfg)
     VCS = parser.get("versioneer", "VCS")  # mandatory
 
     def get(parser, name):