Skip to content

Commit 1abdbdc

Browse files
EddyLXJfacebook-github-bot
authored andcommitted
Fix feature score eviction policy in different trigger mode (#4952)
Summary: Pull Request resolved: #4952 X-link: facebookresearch/FBGEMM#1972 total_id_eviction_trigger_count_ will only populate when ID_COUNT trigger mode is enable. Remove the value check to let feature score support other eviction trigger mode. Reviewed By: emlin Differential Revision: D83583191 fbshipit-source-id: 672e604251bd14b905c1b937cb9f6e22d1af3193
1 parent 32c791f commit 1abdbdc

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

fbgemm_gpu/src/dram_kv_embedding_cache/feature_evict.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ struct FeatureEvictConfig : public torch::jit::CustomClassHolder {
204204
CHECK(feature_score_counter_decay_rates_.has_value());
205205
CHECK(training_id_eviction_trigger_count_.has_value());
206206
CHECK(training_id_keep_count_.has_value());
207-
CHECK(total_id_eviction_trigger_count_.has_value());
208207
CHECK(threshold_calculation_bucket_stride_.has_value());
209208
CHECK(threshold_calculation_bucket_num_.has_value());
210209
CHECK(ttls_in_mins_.has_value());
@@ -215,8 +214,6 @@ struct FeatureEvictConfig : public torch::jit::CustomClassHolder {
215214
<< training_id_eviction_trigger_count_.value()
216215
<< ", training_id_keep_count:"
217216
<< training_id_keep_count_.value()
218-
<< ", total_id_eviction_trigger_count: "
219-
<< total_id_eviction_trigger_count_.value()
220217
<< ", ttls_in_mins: " << ttls_in_mins_.value()
221218
<< ", threshold_calculation_bucket_stride: "
222219
<< threshold_calculation_bucket_stride_.value()

0 commit comments

Comments
 (0)