Skip to content

Commit 74bd30a

Browse files
q10facebook-github-bot
authored andcommitted
Support ROCm 7 in Nova (#4953)
Summary: X-link: facebookresearch/FBGEMM#1976 Pull Request resolved: #4953 Reviewed By: cthi Differential Revision: D83615889 Pulled By: q10 fbshipit-source-id: 59b2b83a42b829c55fe062d8687cd3ebb9b5740e
1 parent 072e323 commit 74bd30a

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

.github/scripts/nova_dir.bash

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,16 @@ elif [[ "$CU_VERSION" == "cu"* ]]; then
4949
echo "[NOVA] Will default to the TORCH_CUDA_ARCH_LIST supplied by the environment!!!"
5050
echo "################################################################################"
5151

52+
53+
elif [[ "$CU_VERSION" == "rocm7.0"* ]]; then
54+
export PYTORCH_ROCM_ARCH="gfx908,gfx90a,gfx942,gfx1201,gfx950"
55+
echo "[NOVA] Set PYTORCH_ROCM_ARCH to: ${PYTORCH_ROCM_ARCH}"
56+
57+
elif [[ "$CU_VERSION" == "rocm6.4"* ]] ||
58+
[[ "$CU_VERSION" == "rocm6.3"* ]]; then
59+
export PYTORCH_ROCM_ARCH="gfx908,gfx90a,gfx942,gfx1201"
60+
echo "[NOVA] Set PYTORCH_ROCM_ARCH to: ${PYTORCH_ROCM_ARCH}"
61+
5262
elif [[ "$CU_VERSION" == "rocm6.4"* ]] ||
5363
[[ "$CU_VERSION" == "rocm6.3"* ]]; then
5464
export PYTORCH_ROCM_ARCH="gfx908,gfx90a,gfx942,gfx1201"

fbgemm_gpu/experimental/gen_ai/src/comm/car.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ void nccl_allreduce(
299299
// a far-off ROCm version check.
300300
// https://github.com/ROCm/rccl/pull/1729
301301
#if (defined(FBGEMM_FBCODE) && defined(USE_ROCM)) || \
302-
(!defined(FBGEMM_FBCODE) && defined(USE_ROCM) && (ROCM_VERSION >= 60600))
302+
(!defined(FBGEMM_FBCODE) && defined(USE_ROCM) && (ROCM_VERSION >= 70200))
303303
if (bias) {
304304
C10D_NCCL_CHECK(
305305
ncclAllReduceWithBias(

0 commit comments

Comments
 (0)