refactor(//core): Address compiler warnings for select

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>

Author: narendasan

core/conversion/conversion.cpp

@@ -361,7 +361,7 @@ void ConvertBlockToNetDef(
                 eval_list->elements().size() == n->outputs().size(),
                 "Size of evaluated results: " << eval_list->elements().size()
                                               << " and node outputs size: " << n->outputs().size() << " must match.");
-            for (int i = 0; i < eval_list->elements().size(); i++) {
+            for (size_t i = 0; i < eval_list->elements().size(); i++) {
               auto eval_output = eval_list.get()->elements()[i];
               LOG_DEBUG(
                   ctx->logger,

core/conversion/converters/impl/select.cpp

@@ -58,7 +58,9 @@ bool add_split(ConversionCtx* ctx, const torch::jit::Node* n, args& args, bool s
   }
 
   auto split_output_ivalue = std::move(torch::jit::IValue(list));
-  auto out = ctx->AssociateValueAndIValue(n->outputs()[0], split_output_ivalue);
+  ctx->AssociateValueAndIValue(n->outputs()[0], split_output_ivalue);
+
+  return true;
 }
 
 auto select_registrations TRTORCH_UNUSED =

core/conversion/evaluators/NodeEvaluatorRegistry.cpp

@@ -58,8 +58,7 @@ class NodeEvaluatorRegistry {
         auto schema = n->maybeSchema();
         TRTORCH_CHECK(
             schema,
-            "Evaluator for " << node_kind.toQualString()
-                             << " only runs on certain schemas, but schema for target"
+            "Evaluator for " << node_kind.toQualString() << " only runs on certain schemas, but schema for target"
                              << " node is not a supported schema variant of " << node_kind.toQualString());
         if (!FindInVec(eval_reg.options.valid_schemas, schema->operator_name())) {
           return nullptr;

tests/core/conversion/converters/test_select.cpp

@@ -228,7 +228,7 @@ TEST(Converters, ATenSplitSizesInScriptingConvertsCorrectly) {
   auto trt_in = at::clone(in);
   auto trt_results = trtorch::tests::util::RunGraphEngine(g, params, {trt_in});
 
-  for (int i = 0; i < jit_results.size(); i++) {
+  for (size_t i = 0; i < jit_results.size(); i++) {
     auto trt = trt_results[i].reshape(jit_results[i].sizes());
     ASSERT_TRUE(trtorch::tests::util::almostEqual(jit_results[i], trt, 2e-6));
   }
@@ -256,7 +256,7 @@ TEST(Converters, ATenSplitSizesinTracingConvertsCorrectly) {
   auto trt_in = at::clone(in);
   auto trt_results = trtorch::tests::util::RunGraphEngine(g, params, {trt_in});
 
-  for (int i = 0; i < jit_results.size(); i++) {
+  for (size_t i = 0; i < jit_results.size(); i++) {
     auto trt = trt_results[i].reshape(jit_results[i].sizes());
     ASSERT_TRUE(trtorch::tests::util::almostEqual(jit_results[i], trt, 2e-6));
   }
@@ -283,7 +283,7 @@ TEST(Converters, ATenSplitFixedConvertsCorrectly) {
   auto trt_in = at::clone(in);
   auto trt_results = trtorch::tests::util::RunGraphEngine(g, params, {trt_in});
 
-  for (int i = 0; i < jit_results.size(); i++) {
+  for (size_t i = 0; i < jit_results.size(); i++) {
     auto trt = trt_results[i].reshape(jit_results[i].sizes());
     ASSERT_TRUE(trtorch::tests::util::almostEqual(jit_results[i], trt, 2e-6));
   }

tests/util/evaluate_graph.cpp

@@ -30,7 +30,7 @@ std::vector<torch::jit::IValue> EvaluateGraph(const torch::jit::Block* b, std::v
     if (eval) {
       if (eval.value().isTuple()) {
         auto eval_list = eval.value().toTuple();
-        for (int i = 0; i < eval_list->elements().size(); i++) {
+        for (size_t i = 0; i < eval_list->elements().size(); i++) {
           auto eval_output = eval_list.get()->elements()[i];
           LOG_DEBUG(
               ctx->logger,