chore: Address review commentas

peri044 · peri044 · commit 6d0b0f64503c · 2022-11-14T18:59:16.000-08:00
Signed-off-by: Dheeraj Peri &lt;peri.dheeraj@gmail.com&gt;
diff --git a/core/partitioning/segmentedblock/SegmentedBlock.h b/core/partitioning/segmentedblock/SegmentedBlock.h
@@ -82,9 +82,15 @@ struct SegmentedBlock {
       max_shapes_ = in_shapes;
     }
   }
-  const std::vector<std::vector<int64_t>> in_shapes() const {
+  const std::vector<std::vector<int64_t>> in_opt_shapes() const {
     return opt_shapes_;
   }
+  const std::vector<std::vector<int64_t>> in_min_shapes() const {
+    return min_shapes_;
+  }
+  const std::vector<std::vector<int64_t>> in_max_shapes() const {
+    return max_shapes_;
+  }
   void register_intypes(std::vector<at::ScalarType>& in_types) {
     in_types_ = in_types;
   }

Original file line number	Diff line number	Diff line change
`@@ -82,9 +82,15 @@ struct SegmentedBlock {`
`82`	`82`	`max_shapes_ = in_shapes;`
`83`	`83`	`}`
`84`	`84`	`}`
`85`		`- const std::vector<std::vector<int64_t>> in_shapes() const {`
	`85`	`+ const std::vector<std::vector<int64_t>> in_opt_shapes() const {`
`86`	`86`	`return opt_shapes_;`
`87`	`87`	`}`
	`88`	`+ const std::vector<std::vector<int64_t>> in_min_shapes() const {`
	`89`	`+ return min_shapes_;`
	`90`	`+ }`
	`91`	`+ const std::vector<std::vector<int64_t>> in_max_shapes() const {`
	`92`	`+ return max_shapes_;`
	`93`	`+ }`
`88`	`94`	`void register_intypes(std::vector<at::ScalarType>& in_types) {`
`89`	`95`	`in_types_ = in_types;`
`90`	`96`	`}`