fix: add a warning msg when renaming itensors

Signed-off-by: Bo Wang <[email protected]>

Author: bowang007

core/conversion/conversion.cpp

@@ -188,7 +188,7 @@ void AddInputs(
       ctx->input_is_dynamic = true;
     }
 
-    ctx->value_tensor_map[in] = trt_in;
+    ctx->AddNamedTensor(in, trt_in);
     ctx->num_inputs += 1;
   }
 

core/conversion/conversionctx/ConversionCtx.cpp

@@ -130,8 +130,11 @@ ConversionCtx::~ConversionCtx() {
 }
 
 nvinfer1::ITensor* ConversionCtx::AssociateValueAndTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor) {
+  if (!AddNamedTensor(value, tensor)) {
+    LOG_WARNING(
+        "Trying to rewrite the name " << value->debugName() << " to a named ITensor " << tensor->getName() << ".");
+  }
   tensor->setName(value->debugName().c_str());
-  this->value_tensor_map[value] = tensor;
   return tensor;
 }
 
@@ -140,6 +143,12 @@ torch::jit::IValue* ConversionCtx::AssociateValueAndIValue(const torch::jit::Val
   return &this->evaluated_value_map[value];
 }
 
+bool ConversionCtx::AddNamedTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor) {
+  value_tensor_map[value] = tensor;
+  auto ret = named_tensors.insert(tensor);
+  return ret.second;
+}
+
 std::string ConversionCtx::SerializeEngine() {
 #if NV_TENSORRT_MAJOR > 7
   auto serialized_network = builder->buildSerializedNetwork(*net, *cfg);

core/conversion/conversionctx/ConversionCtx.h

@@ -46,6 +46,7 @@ struct ConversionCtx {
   ConversionCtx(BuilderSettings settings);
   std::string SerializeEngine();
   nvinfer1::ITensor* AssociateValueAndTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor);
+  bool AddNamedTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor);
   torch::jit::IValue* AssociateValueAndIValue(const torch::jit::Value* value, torch::jit::IValue tensor);
   bool CheckLayerAddition(const torch::jit::Node* n);
 
@@ -69,6 +70,9 @@ struct ConversionCtx {
 
   std::unordered_map<const torch::jit::Value*, nvinfer1::ITensor*> value_tensor_map;
   std::unordered_map<const torch::jit::Value*, torch::jit::IValue> evaluated_value_map;
+
+  // record already named ITensors to prevent rewriting another name to the same tensor
+  std::unordered_set<nvinfer1::ITensor*> named_tensors;
 };
 
 } // namespace conversion