Skip to content

Commit beace9b

Browse files
committed
revert the limit pr build will address it in another issue for fail fast
1 parent 008c254 commit beace9b

9 files changed

+1147
-65
lines changed

.github/scripts/filter-matrix.py

Lines changed: 6 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -10,23 +10,6 @@
1010
disabled_python_versions: List[str] = []
1111

1212

13-
def replace_aarch64_container_image(item: Dict[str, Any]) -> Dict[str, Any] | None:
14-
if item["gpu_arch_type"] == "cuda-aarch64":
15-
if item["desired_cuda"] == "cu128":
16-
# pytorch image:pytorch/manylinuxaarch64-builder:cuda12.8 comes with glibc2.28
17-
# however, TensorRT requires glibc2.31 on aarch64 platform
18-
# TODO: in future, if pytorch supports aarch64 with glibc2.31, we should switch to use the pytorch image
19-
# item["container_image"] = "sameli/manylinux_2_34_aarch64_cuda_12.8"
20-
item["container_image"] = "quay.io/pypa/manylinux_2_34_aarch64"
21-
return item
22-
else:
23-
# for aarch64 do not test on other cuda versions
24-
return None
25-
# if it is not aarch64, do nothing and return the item
26-
else:
27-
return item
28-
29-
3013
def main(args: list[str]) -> None:
3114
parser = argparse.ArgumentParser()
3215
parser.add_argument(
@@ -36,14 +19,6 @@ def main(args: list[str]) -> None:
3619
default="",
3720
)
3821

39-
parser.add_argument(
40-
"--limit-pr-builds",
41-
help="Limit PR builds to single python/cuda config(py3.11/cu12.8): true or false",
42-
type=str,
43-
choices=["true", "false"],
44-
default=os.getenv("LIMIT_PR_BUILDS", "false"),
45-
)
46-
4722
options = parser.parse_args(args)
4823

4924
if options.matrix == "":
@@ -55,17 +30,13 @@ def main(args: list[str]) -> None:
5530
for item in includes:
5631
if item["python_version"] in disabled_python_versions:
5732
continue
58-
if options.limit_pr_builds == "true":
59-
# currently if it is the pr build, it build using py3.9 with all cuda versions, we want to change to py3.11 with singlecu12.8
60-
if item["desired_cuda"] == "cu128":
61-
item["python_version"] = "3.11"
62-
build_names = item["build_name"].split("-")
63-
build_names[1] = "py3_11"
64-
item["build_name"] = "-".join(build_names)
65-
item = replace_aarch64_container_image(item)
66-
filtered_includes.append(item)
33+
if item["gpu_arch_type"] == "cuda-aarch64":
34+
# pytorch image:pytorch/manylinuxaarch64-builder:cuda12.8 comes with glibc2.28
35+
# however, TensorRT requires glibc2.31 on aarch64 platform
36+
# TODO: in future, if pytorch supports aarch64 with glibc2.31, we should switch to use the pytorch image
37+
item["container_image"] = "quay.io/pypa/manylinux_2_34_aarch64"
38+
filtered_includes.append(item)
6739
else:
68-
item = replace_aarch64_container_image(item)
6940
filtered_includes.append(item)
7041
filtered_matrix_dict = {}
7142
filtered_matrix_dict["include"] = filtered_includes

0 commit comments

Comments
 (0)