refactor: refactor the RecordNewTensor function

Signed-off-by: Bo Wang <[email protected]>

Author: bowang007

core/conversion/conversionctx/ConversionCtx.cpp

@@ -130,11 +130,8 @@ ConversionCtx::~ConversionCtx() {
 }
 
 nvinfer1::ITensor* ConversionCtx::AssociateValueAndTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor) {
-  if (!RecordNewTensor(value, tensor)) {
-    LOG_WARNING(
-        "Trying to rewrite the name " << value->debugName() << " to a named ITensor " << tensor->getName() << ".");
-  }
-  tensor->setName(value->debugName().c_str());
+  RecordNewTensor(value, tensor);
+
   return tensor;
 }
 
@@ -143,10 +140,13 @@ torch::jit::IValue* ConversionCtx::AssociateValueAndIValue(const torch::jit::Val
   return &this->evaluated_value_map[value];
 }
 
-bool ConversionCtx::RecordNewTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor) {
+void ConversionCtx::RecordNewTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor) {
   value_tensor_map[value] = tensor;
   auto ret = known_tensors.insert(tensor);
-  return ret.second;
+  if (!ret) {
+    LOG_WARNING(
+        "Trying to record the value " << value->debugName() << " with the ITensor " << tensor->getName() << " again.");
+  }
 }
 
 std::string ConversionCtx::SerializeEngine() {

core/conversion/conversionctx/ConversionCtx.h

@@ -46,7 +46,7 @@ struct ConversionCtx {
   ConversionCtx(BuilderSettings settings);
   std::string SerializeEngine();
   nvinfer1::ITensor* AssociateValueAndTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor);
-  bool RecordNewTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor);
+  void RecordNewTensor(const torch::jit::Value* value, nvinfer1::ITensor* tensor);
   torch::jit::IValue* AssociateValueAndIValue(const torch::jit::Value* value, torch::jit::IValue tensor);
   bool CheckLayerAddition(const torch::jit::Node* n);