fix the engine_cache bug #3915
Open
fix the engine_cache bug #3915
+38
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_engine_cache.py 2025-11-20 21:15:55.433017+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_engine_cache.py 2025-11-20 21:16:43.787199+00:00
@@ -28,10 +28,11 @@
self.engine_cache_dir = engine_cache_dir
if not os.path.exists(self.engine_cache_dir):
os.makedirs(self.engine_cache_dir, exist_ok=True)
self.hashes = {}
+
def exist(self, hash: str) -> bool:
return hash in self.hashes
def save(
self,
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_engine_cache.py 2025-11-20 21:16:09.872580+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_engine_cache.py 2025-11-20 21:16:52.726852+00:00
@@ -28,10 +28,11 @@
self.engine_cache_dir = engine_cache_dir
if not os.path.exists(self.engine_cache_dir):
os.makedirs(self.engine_cache_dir, exist_ok=True)
self.hashes = {}
+
def exist(self, hash: str) -> bool:
return hash in self.hashes
def save(
self,
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_engine_cache.py 2025-11-20 21:16:09.968505+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_engine_cache.py 2025-11-20 21:16:54.092908+00:00
@@ -28,10 +28,11 @@
self.engine_cache_dir = engine_cache_dir
if not os.path.exists(self.engine_cache_dir):
os.makedirs(self.engine_cache_dir, exist_ok=True)
self.hashes = {}
+
def exist(self, hash: str) -> bool:
return hash in self.hashes
def save(
self,
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_engine_cache.py 2025-11-20 21:16:14.709932+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_engine_cache.py 2025-11-20 21:16:57.038199+00:00
@@ -28,10 +28,11 @@
self.engine_cache_dir = engine_cache_dir
if not os.path.exists(self.engine_cache_dir):
os.makedirs(self.engine_cache_dir, exist_ok=True)
self.hashes = {}
+
def exist(self, hash: str) -> bool:
return hash in self.hashes
def save(
self,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The engine_cache bug is introduced due to recent cpu/memory optimzation feature where we moved the cache insert logic
Previously, cache_insert will only happen after we actually build the engine.
Now we moved to convert_module, so it is possible the engine is the cached one and we insert cache again.
The fix is to add a check if the cache exists already, then do not insert again.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: