-
Notifications
You must be signed in to change notification settings - Fork 322
[not for land] debug logging for float8 training #2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vkuzo
wants to merge
3
commits into
main
Choose a base branch
from
gh/vkuzo/104/head
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2701
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New FailuresAs of commit 6a7c700 with merge base 2db4c76 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A lightweight logging framework for
Float8Linear
.two step usage:
_debug_logging_fn
function onFloat8LinearConfig
to a user defined function, with the inputs being the fqn, the gemm name, anda_hp
,b_hp
,a_fp8
andb_fp8
. This is generic allows that it allows for logging comparisons between pairs of gemm inputs, comparisons between gemm outputs, performance of gemms, etc._populate_debug_fqns
to populate debug FQN namesif 1 and 2 are done, then every forward and backward
_debug_logging_fn
will be called for each of the 3 gemms in fwd/bwd.example usage:
Test Plan:
> pytest test/float8/test_base.py -s -x -k test_debug_logging ... test/float8/test_base.py fqn: 0, gemm_name: output, sqnr: 29.125 fqn: 1.1, gemm_name: output, sqnr: 28.5 fqn: 1.1, gemm_name: grad_input, sqnr: 33.5 fqn: 1.1, gemm_name: grad_weight, sqnr: 38.5 fqn: 0, gemm_name: grad_input, sqnr: 22.5 fqn: 0, gemm_name: grad_weight, sqnr: 23.875
Reviewers:
Subscribers:
Tasks:
Tags: