From 63f5a16774643f574caebdf70f36ed9f927ec520 Mon Sep 17 00:00:00 2001 From: Klaus Zimmermann Date: Fri, 1 Aug 2025 15:59:42 +0200 Subject: [PATCH] Replace direct calls to setup.py with pip equivalents --- .github/scripts/unittest-linux/install.sh | 2 +- .github/scripts/unittest-windows/install.sh | 2 +- .github/workflows/integration-test.yml | 2 +- docs/source/build.linux.rst | 4 ++-- docs/source/build.windows.rst | 6 +++--- packaging/torchaudio/bld.bat | 2 +- packaging/torchaudio/build.sh | 2 +- tools/travis/install.sh | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/scripts/unittest-linux/install.sh b/.github/scripts/unittest-linux/install.sh index 24dd7e3476..ffbe2b5b6b 100755 --- a/.github/scripts/unittest-linux/install.sh +++ b/.github/scripts/unittest-linux/install.sh @@ -82,7 +82,7 @@ conda install --quiet -y ninja cmake printf "* Installing torchaudio\n" export BUILD_CPP_TEST=1 -python setup.py install +pip install . -v --no-build-isolation # 3. Install Test tools printf "* Installing test tools\n" diff --git a/.github/scripts/unittest-windows/install.sh b/.github/scripts/unittest-windows/install.sh index 0dd4997323..a6d2c8beba 100644 --- a/.github/scripts/unittest-windows/install.sh +++ b/.github/scripts/unittest-windows/install.sh @@ -46,7 +46,7 @@ printf "* Installing fsspec\n" pip install --trusted-host pypi.org --trusted-host files.pythonhosted.org fsspec printf "* Installing torchaudio\n" -"$root_dir/packaging/vc_env_helper.bat" python setup.py install +"$root_dir/packaging/vc_env_helper.bat" pip install . -v --no-build-isolation # 3. Install Test tools printf "* Installing test tools\n" diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml index 65aaf9c0e5..db293ae2e3 100644 --- a/.github/workflows/integration-test.yml +++ b/.github/workflows/integration-test.yml @@ -29,7 +29,7 @@ # python -m pip install --quiet --upgrade pip # python -m pip install --quiet --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html # python -m pip install --quiet pytest requests cmake ninja deep-phonemizer sentencepiece flashlight-text git+https://github.com/kpu/kenlm -# python setup.py install +# python -m pip install . -v --no-build-isolation # - name: Run integration test # run: | # cd test && pytest integration_tests -v --use-tmp-hub-dir diff --git a/docs/source/build.linux.rst b/docs/source/build.linux.rst index 864078257d..0809293822 100644 --- a/docs/source/build.linux.rst +++ b/docs/source/build.linux.rst @@ -37,7 +37,7 @@ Here, we install nightly build. .. code-block:: - python setup.py develop + pip install -e . -v --no-build-isolation .. note:: Due to the complexity of build process, TorchAudio only supports in-place build. @@ -57,4 +57,4 @@ To build single version FFmpeg extension, FFmpeg binaries must be provided by us .. code-block:: conda install -c conda-forge ffmpeg - FFMPEG_ROOT=${CONDA_PREFIX} python setup.py develop + FFMPEG_ROOT=${CONDA_PREFIX} pip install -e . -v --no-build-isolation diff --git a/docs/source/build.windows.rst b/docs/source/build.windows.rst index 732f246865..88e072d910 100644 --- a/docs/source/build.windows.rst +++ b/docs/source/build.windows.rst @@ -119,12 +119,12 @@ Now that we have everything ready, we can build TorchAudio. .. code-block:: # In Command Prompt - python setup.py develop + pip install -e . -v --no-build-isolation .. code-block:: # In Bash - python setup.py develop + pip install -e . -v --no-build-isolation .. note:: Due to the complexity of build process, TorchAudio only supports in-place build. @@ -144,7 +144,7 @@ To build single version FFmpeg extension, FFmpeg binaries must be provided by us .. code-block:: conda install -c conda-forge ffmpeg - FFMPEG_ROOT=${CONDA_PREFIX}/Library python setup.py develop + FFMPEG_ROOT=${CONDA_PREFIX}/Library pip install -e . -v --no-build-isolation [Optional] Building FFmpeg from source diff --git a/packaging/torchaudio/bld.bat b/packaging/torchaudio/bld.bat index 6b31d4319c..3e5a02349b 100644 --- a/packaging/torchaudio/bld.bat +++ b/packaging/torchaudio/bld.bat @@ -2,4 +2,4 @@ set IS_CONDA=1 -python setup.py install --single-version-externally-managed --record=record.txt +python -m pip install . -vv diff --git a/packaging/torchaudio/build.sh b/packaging/torchaudio/build.sh index 23bb306b02..ccfc492b92 100644 --- a/packaging/torchaudio/build.sh +++ b/packaging/torchaudio/build.sh @@ -14,4 +14,4 @@ if [ "${USE_CUDA}" == "1" ] ; then fi fi shopt -u nocasematch -python setup.py install --single-version-externally-managed --record=record.txt +python -m pip install . -vv --no-build-isolation diff --git a/tools/travis/install.sh b/tools/travis/install.sh index 3586d5bd08..6444ee634b 100644 --- a/tools/travis/install.sh +++ b/tools/travis/install.sh @@ -54,7 +54,7 @@ pip install -r requirements.txt # Install the following only if running tests if [[ "$SKIP_INSTALL" != "true" ]]; then # TorchAudio CPP Extensions - python setup.py install + python -m pip install . -vv --no-build-isolation fi if [[ "$RUN_EXAMPLE_TESTS" == "true" ]]; then