-
Notifications
You must be signed in to change notification settings - Fork 719
[STABLE ABI] Stable forced_align on cpu #4022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable_accessor
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4022
Note: Links to docs will display an error until the docs builds have been completed. ❌ 21 New FailuresAs of commit 93c6d68 with merge base bdd9c72 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Note: this commit now depends on the |
This PR passes all tests for |
Hello, is there a chance to get any features or improvements from #3787 merged? on the other side, I managed to remove the torch dependency completely from the FA api, so I guess it's doable, only the input |
Hi @MahmoudAshraf97 , we're currently trying to migrate these ops to be ABI-stable, which is our current top priority. Unfortunately, we won't have the bandwidth to consider improvements like in #3787 at the moment, sorry. It's possible that we'll be able to re-consider in the future, but the near-term goal is for torchaudio to be stable while minimizing maintenance requirements. |
The CI used to run fine. A recent change to the stable ABI now leads to |
This PR ports the
forced_align
code to the stable ABI. It uses the temporary Accessor class defined in thestable_accessor
PR.