Skip to content

Conversation

samanklesaria
Copy link
Collaborator

@samanklesaria samanklesaria commented Aug 20, 2025

This PR mostly changes references to that were phrased as "will be" (in the context of deprecating IO functionality) to "have been". A variety of issues noticed along the way that were too small for their own PRs have been included as well.

Copy link

pytorch-bot bot commented Aug 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4057

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 20, 2025
@samanklesaria samanklesaria changed the base branch from main to remove_dropping_support August 20, 2025 16:38
@samanklesaria samanklesaria marked this pull request as ready for review August 20, 2025 18:31
@samanklesaria samanklesaria requested a review from a team as a code owner August 20, 2025 18:31
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, approving with requests for follow-up in other PR. Since this PR is made against remove_dropping_support and not against main, please be extra careful with the merge.

@samanklesaria samanklesaria changed the base branch from remove_dropping_support to main September 2, 2025 14:58
@pearu pearu added this to the 2.9 milestone Sep 2, 2025
@samanklesaria samanklesaria merged commit 0d2d014 into main Sep 2, 2025
3 checks passed
@samanklesaria samanklesaria deleted the docs_update branch September 2, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants