Skip to content

Commit 01905db

Browse files
trivedivivekfacebook-github-bot
authored andcommitted
Fix regression with 8 bit quant mat mul. (#15445)
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Reviewed By: SS-JIA Differential Revision: D85767668
1 parent c0df044 commit 01905db

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

backends/vulkan/runtime/graph/ops/glsl/linear_qcsnw_tiled.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ linear_qcsnw_tiled:
1212
WEIGHT_STORAGE: texture2d
1313
SCALES_STORAGE: texture2d
1414
TILE_ROWS: 4
15-
TILE_TXCOLS: 2
15+
TILE_TXCOLS: 1
1616
QUANT_NBITS: 8
1717
generate_variant_forall:
1818
TILE_ROWS:

backends/vulkan/runtime/graph/ops/impl/QuantizedLinearQCSNW.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ utils::uvec3 linear_qcsnw_tiled_global_wg_size(
7373
}
7474

7575
// Number of output texels in the output tile
76-
uint32_t out_tile_ntxcols = 2;
76+
uint32_t out_tile_ntxcols = 1;
7777
if (quant_nbits == 4) {
7878
out_tile_ntxcols = 2;
7979
}
@@ -325,7 +325,7 @@ void add_linear_qcsnw_tiled_node(
325325
}
326326

327327
// Number of output texels in the output tile
328-
uint32_t out_tile_ntxcols = 2;
328+
uint32_t out_tile_ntxcols = 1;
329329
if (quant_nbits == 4) {
330330
out_tile_ntxcols = 2;
331331
}

0 commit comments

Comments
 (0)