init

Author: metascroy

.github/workflows/apple-perf.yml

@@ -315,6 +315,9 @@ jobs:
   build-benchmark-app:
     name: build-benchmark-app
     uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
+    uses: maxim-lobanov/setup-xcode@v1
+        with:
+          xcode-version: '16.0'
     needs:
       - set-parameters
     secrets: inherit

build/build_apple_frameworks.sh

@@ -8,7 +8,7 @@
 set -euo pipefail
 
 SOURCE_ROOT_DIR=""
-OUTPUT="cmake-out"
+OUTPUT="cmake-out-apple"
 MODE="Release"
 TOOLCHAIN=""
 PYTHON=$(which python3)
@@ -76,7 +76,7 @@ usage() {
   echo "SOURCE_ROOT_DIR defaults to the current directory if not provided."
   echo
   echo "Options:"
-  echo "  --output=DIR         Output directory. Default: 'cmake-out'"
+  echo "  --output=DIR         Output directory. Default: 'cmake-out-apple'"
   echo "  --Debug              Use Debug build mode. Default: Uses Release build mode."
   echo "  --toolchain=FILE     Cmake toolchain file. Default: '\$SOURCE_ROOT_DIR/third-party/ios-cmake/ios.toolchain.cmake'"
   echo "  --python=FILE        Python executable path. Default: Path of python3 found in the current \$PATH"
@@ -188,7 +188,7 @@ echo "Exporting headers"
 mkdir -p "$HEADERS_PATH"
 
 # Set BUCK2 to the path of the buck2 executable in $OUTPUT/*/buck2-bin/buck2-*
-BUCK2=$(find . -type f -path '*/buck2-bin/buck2-*' | head -n 1)
+BUCK2=$(find ${SOURCE_ROOT_DIR}/buck2-bin -type f -name "buck2-*" | head -n 1)
 if [[ -z "$BUCK2" ]]; then
   echo "Could not find buck2 executable in any buck2-bin directory under $OUTPUT"
   BUCK2=$(which buck2)

extension/llm/export/partitioner_lib.py

@@ -158,11 +158,7 @@ def _validate_ios_version() -> None:
         op_linear_quantizer_config=op_linear_quantizer_config,
     )
 
-    # ExecuTorch does not build CoreML delegate runtime to handle state
-    # when using OSS scripts, so we define take_over_mutable_buffer = False,
-    # even when target is iOS18
-    # take_over_mutable_buffer = minimum_deployment_target >= ct.target.iOS18
-    take_over_mutable_buffer = False
+    take_over_mutable_buffer = minimum_deployment_target >= ct.target.iOS18
     return CoreMLPartitioner(  # pyre-fixme[16]
         compile_specs=compile_specs,
         take_over_mutable_buffer=take_over_mutable_buffer,