Cmake

Author: jackzhxng

examples/models/llama/runner/CMakeLists.txt

@@ -77,10 +77,18 @@ add_subdirectory(
   ${EXECUTORCH_ROOT}/extension/llm/tokenizers/third-party/re2
   ${CMAKE_CURRENT_BINARY_DIR}/re2
 )
+add_subdirectory(
+  ${EXECUTORCH_ROOT}/extension/llm/tokenizers/third-party/json
+  ${CMAKE_CURRENT_BINARY_DIR}/json
+)
+target_include_directories(llama_runner
+  PRIVATE ${CMAKE_INSTALL_PREFIX}/include
+          ${CMAKE_CURRENT_SOURCE_DIR}/../tokenizers/third-party/llama.cpp-unicode
+)
 set(CMAKE_POSITION_INDEPENDENT_CODE ${_pic_flag})
 
 set(llama_runner_deps executorch extension_data_loader extension_module
-                      extension_tensor re2::re2
+                      extension_tensor re2::re2 nlohmann_json::nlohmann_json
 )
 
 target_link_libraries(llama_runner PUBLIC ${llama_runner_deps})

examples/models/llama/runner/targets.bzl

@@ -49,7 +49,7 @@ def define_common_targets():
                 "//executorch/runtime/core/exec_aten/util:tensor_util" + aten_suffix,
                 "//executorch/examples/models/llama/tokenizer:tiktoken",
                 "//pytorch/tokenizers:llama2c_tokenizer",
-		"//pytorch/tokenizers:hf_tokenizer",
+                "//pytorch/tokenizers:hf_tokenizer",
             ] + (_get_operator_lib(aten)) + ([
                 # Vulkan API currently cannot build on some platforms (e.g. Apple, FBCODE)
                 # Therefore enable it explicitly for now to avoid failing tests

extension/llm/tokenizer/CMakeLists.txt

@@ -28,6 +28,15 @@ add_subdirectory(
   ${CMAKE_CURRENT_SOURCE_DIR}/../tokenizers/third-party/re2
   ${CMAKE_CURRENT_BINARY_DIR}/re2
 )
+# add_subdirectory(
+#   ${CMAKE_CURRENT_SOURCE_DIR}/../tokenizers/third-party/json
+#   ${CMAKE_CURRENT_BINARY_DIR}/json
+# )
+# target_include_directories(extension_llm_tokenizer
+#   PRIVATE ${CMAKE_INSTALL_PREFIX}/include
+#           ${CMAKE_CURRENT_SOURCE_DIR}/../tokenizers/third-party/llama.cpp-unicode
+# )
+
 set(CMAKE_POSITION_INDEPENDENT_CODE ${_pic_flag})
 
 list(TRANSFORM _extension_llm_tokenizer__srcs PREPEND "${EXECUTORCH_ROOT}/")
@@ -38,7 +47,7 @@ target_include_directories(
                                  ${CMAKE_CURRENT_SOURCE_DIR}/../tokenizers/include
 )
 
-target_link_libraries(extension_llm_tokenizer re2::re2)
+# target_link_libraries(extension_llm_tokenizer re2::re2 nlohmann_json::nlohmann_json )
 target_compile_options(
   extension_llm_tokenizer PUBLIC ${_common_compile_options}
 )