Skip to content

Commit 0bfbe44

Browse files
NXP backend: Fix incorrect linear test. (#13760)
### Summary This PR fixes an incorrect `linear` test without a bias. ### Test plan Unit test provided.
1 parent 176800e commit 0bfbe44

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

backends/nxp/tests/ir/converter/node_converter/test_linear_converter.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from executorch.backends.nxp.tests.executorch_pipeline import to_edge_program
1111
from executorch.backends.nxp.tests.executors import convert_run_compare
1212
from executorch.backends.nxp.tests.models import LinearModule
13+
from executorch.exir.dialects._ops import ops as exir_ops
1314

1415

1516
@pytest.fixture(autouse=True)
@@ -26,15 +27,23 @@ def test_linear_conversion__with_bias():
2627

2728
input_data = np.random.random(input_shape).astype(np.float32)
2829

29-
convert_run_compare(edge_program, input_data=input_data, atol=1.0e-6)
30+
nodes = list(edge_program.graph.nodes)
31+
assert nodes[4].target == exir_ops.edge.aten.addmm.default
32+
assert len(nodes[4].args) == 3 # Has bias.
33+
34+
convert_run_compare(edge_program, input_data=input_data)
3035

3136

3237
def test_linear_conversion__without_bias():
3338
input_shape = (10, 32)
3439
edge_program = to_edge_program(
35-
LinearModule(bias=True), input_shape
40+
LinearModule(bias=False), input_shape
3641
).exported_program()
3742

3843
input_data = np.random.random(input_shape).astype(np.float32)
3944

40-
convert_run_compare(edge_program, input_data=input_data, atol=1.0e-6)
45+
nodes = list(edge_program.graph.nodes)
46+
assert nodes[3].target == exir_ops.edge.aten.mm.default
47+
assert len(nodes[3].args) == 2 # No bias.
48+
49+
convert_run_compare(edge_program, input_data=input_data)

0 commit comments

Comments
 (0)