Skip to content

Commit 0ca47ef

Browse files
committed
address some feedback and disable some jobs for now
1 parent 5ef3804 commit 0ca47ef

File tree

2 files changed

+35
-22
lines changed

2 files changed

+35
-22
lines changed

.ci/scripts/test_wheel_package_qnn.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ echo "Checking for .so files inside the wheel..."
122122
WHEEL_SO_FILES=$(unzip -l "$WHEEL_FILE" | awk '{print $4}' | grep "executorch/backends/qualcomm/python" || true)
123123
if [ -z "$WHEEL_SO_FILES" ]; then
124124
echo "WARNING: No .so files found in wheel under executorch/backends/qualcomm/python"
125+
exit 1
125126
else
126127
echo "Wheel contains the following .so files:"
127128
echo "$WHEEL_SO_FILES"

.github/workflows/pull.yml

Lines changed: 34 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -34,30 +34,30 @@ jobs:
3434
3535
PYTHON_EXECUTABLE=python bash .ci/scripts/test_wheel_package_qnn.sh
3636
37-
test-setup-linux-gcc:
38-
name: test-setup-linux-gcc
39-
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
40-
permissions:
41-
id-token: write
42-
contents: read
43-
strategy:
44-
fail-fast: false
45-
with:
46-
runner: linux.2xlarge
47-
docker-image: ci-image:executorch-ubuntu-22.04-gcc9
48-
submodules: 'recursive'
49-
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
50-
timeout: 90
51-
script: |
52-
# The generic Linux job chooses to use base env, not the one setup by the image
53-
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
54-
conda activate "${CONDA_ENV}"
37+
# test-setup-linux-gcc:
38+
# name: test-setup-linux-gcc
39+
# uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
40+
# permissions:
41+
# id-token: write
42+
# contents: read
43+
# strategy:
44+
# fail-fast: false
45+
# with:
46+
# runner: linux.2xlarge
47+
# docker-image: ci-image:executorch-ubuntu-22.04-gcc9
48+
# submodules: 'recursive'
49+
# ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
50+
# timeout: 90
51+
# script: |
52+
# # The generic Linux job chooses to use base env, not the one setup by the image
53+
# CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
54+
# conda activate "${CONDA_ENV}"
5555

56-
BUILD_TOOL="cmake"
56+
# BUILD_TOOL="cmake"
5757

58-
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh --build-tool "${BUILD_TOOL}"
59-
# Build and test ExecuTorch with the add model on portable backend.
60-
PYTHON_EXECUTABLE=python bash .ci/scripts/test_model.sh "add" "${BUILD_TOOL}" "portable"
58+
# PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh --build-tool "${BUILD_TOOL}"
59+
# # Build and test ExecuTorch with the add model on portable backend.
60+
# PYTHON_EXECUTABLE=python bash .ci/scripts/test_model.sh "add" "${BUILD_TOOL}" "portable"
6161

6262
# test-models-linux-basic:
6363
# name: test-models-linux-basic
@@ -875,16 +875,28 @@ jobs:
875875
# CMAKE_ARGS="-DEXECUTORCH_BUILD_NXP_NEUTRON=ON" \
876876
# .ci/scripts/setup-linux.sh --build-tool "cmake"
877877

878+
<<<<<<< HEAD
878879
# Install test requirements
879880
# pip install -r backends/nxp/requirements-tests-pypi.txt
880881
# pip install -r backends/nxp/requirements-tests-eiq.txt
882+
=======
883+
# # Install test requirements
884+
# pip install -r backends/nxp/requirements-tests-pypi.txt
885+
# pip install -r backends/nxp/requirements-tests-eiq.txt
886+
>>>>>>> 5c905fcadd (address some feedback and disable some jobs for now)
881887

882888
# # Run pytest
883889
# PYTHON_EXECUTABLE=python bash backends/nxp/run_unittests.sh
884890

891+
<<<<<<< HEAD
885892
# Run aot examples:
886893
# PYTHON_EXECUTABLE=python bash examples/nxp/run_aot_example.sh cifar10
887894
# PYTHON_EXECUTABLE=python bash examples/nxp/run_aot_example.sh mobilenetv2
895+
=======
896+
# # Run aot examples:
897+
# PYTHON_EXECUTABLE=python bash examples/nxp/run_aot_example.sh cifar10
898+
# PYTHON_EXECUTABLE=python bash examples/nxp/run_aot_example.sh mobilenetv2
899+
>>>>>>> 5c905fcadd (address some feedback and disable some jobs for now)
888900

889901

890902
# test-samsung-models-linux:

0 commit comments

Comments
 (0)