Skip to content

Commit 11034ee

Browse files
committed
fix typo and argparser issue
1 parent 229a3f6 commit 11034ee

File tree

12 files changed

+7
-57
lines changed

12 files changed

+7
-57
lines changed

.ci/scripts/build-qnn-sdk.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ build_qnn_backend() {
1818
export EXECUTORCH_ROOT="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")/../.." && pwd)"
1919

2020
parallelism=$(( $(nproc) - 1 ))
21-
bash backends/qualcomm/scripts/build.sh --skip_linux_android --skip_linux_embedding --job_number ${parallelism} --release
21+
bash backends/qualcomm/scripts/build.sh --skip_linux_android --skip_linux_embedded --job_number ${parallelism} --release
2222
}
2323

2424
set_up_aot() {

backends/qualcomm/scripts/build.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ usage() {
2020
echo ", and if you want to build the android version of executor runner"
2121
echo ", you need to export ANDROID_NDK_ROOT=/path/to/android_ndkXX"
2222
echo "(or export TOOLCHAIN_ROOT_HOST=/path/to/sysroots/xx_host, "
23-
echo "TOOLCHAIN_ROOT_TARGET=/path/to/sysroots/xx_target for linux embedded with --enable_linux_embedding)"
23+
echo "TOOLCHAIN_ROOT_TARGET=/path/to/sysroots/xx_target for linux embedded with --enable_linux_embedded)"
2424
echo "e.g.: executorch$ ./backends/qualcomm/scripts/build.sh --skip_x86_64"
2525
exit 1
2626
}
@@ -46,7 +46,7 @@ if [ -z BUCK2 ]; then
4646
BUCK2="buck2"
4747
fi
4848

49-
long_options=skip_x86_64,skip_linux_android,skip_linux_embedding,enable_linux_embedding,no_clean,release,job_number:
49+
long_options=skip_x86_64,skip_linux_android,skip_linux_embedded,enable_linux_embedded,no_clean,release,job_number:
5050

5151
parsed_args=$(getopt -a --options '' --longoptions $long_options --name "$0" -- "$@")
5252
eval set -- "$parsed_args"
@@ -56,8 +56,8 @@ while true ; do
5656
case "$1" in
5757
--skip_x86_64) BUILD_X86_64="false"; shift;;
5858
--skip_linux_android) BUILD_ANDROID="false"; shift;;
59-
--skip_linux_embedding) BUILD_OE_LINUX="false"; shift;;
60-
--enable_linux_embedding) BUILD_ANDROID="false"; BUILD_OE_LINUX="true"; shift;;
59+
--skip_linux_embedded) BUILD_OE_LINUX="false"; shift;;
60+
--enable_linux_embedded) BUILD_ANDROID="false"; BUILD_OE_LINUX="true"; shift;;
6161
--no_clean) CLEAN="false"; shift;;
6262
--release) BUILD_TYPE="Release"; shift;;
6363
--job_number) BUILD_JOB_NUMBER="$2"; shift 2;;

docs/source/backends-qualcomm.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ cd $EXECUTORCH_ROOT
134134
# android target
135135
./backends/qualcomm/scripts/build.sh
136136
# (optional) linux embedded target
137-
./backends/qualcomm/scripts/build.sh --enable_linux_embedding
137+
./backends/qualcomm/scripts/build.sh --enable_linux_embedded
138138
# for release build
139139
./backends/qualcomm/scripts/build.sh --release
140140
```

examples/qualcomm/oss_scripts/llama/llama.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,12 +1154,6 @@ def _build_parser():
11541154
help="Override the dtype of the model (default is the checkpoint dtype). Options: fp32",
11551155
)
11561156

1157-
parser.add_argument(
1158-
"--pre_gen_pte",
1159-
help="Run the pre-generated llama in the given directory.",
1160-
type=str,
1161-
)
1162-
11631157
parser.add_argument(
11641158
"--model_mode",
11651159
help="Export and inference kv mode, hybrid mode, or lookahead decoding mode",

examples/qualcomm/oss_scripts/moshi/mimi.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -524,12 +524,6 @@ def main(args):
524524
default=10.0,
525525
)
526526

527-
parser.add_argument(
528-
"--pre_gen_pte",
529-
help="Run the pre-generated mimi encoder/decoder in the given directory.",
530-
type=str,
531-
)
532-
533527
parser.add_argument(
534528
"--use_cpu_encoder",
535529
help="Enable this flag to perform encoder with cpu.",

examples/qualcomm/oss_scripts/qwen2_5/qwen2_5.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,6 @@ def main(args):
210210
type=str,
211211
)
212212

213-
parser.add_argument(
214-
"--pre_gen_pte",
215-
help="Run the pre-generated Qwen in the given directory.",
216-
type=str,
217-
)
218-
219213
parser.add_argument(
220214
"--prompt",
221215
help="User prompts for Qwen.",

examples/qualcomm/oss_scripts/t5/t5.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -327,11 +327,6 @@ def post_process():
327327
default="./t5",
328328
type=str,
329329
)
330-
parser.add_argument(
331-
"--pre_gen_pte",
332-
help="Run the pre-generated t5 in the given directory.",
333-
type=str,
334-
)
335330
parser.add_argument(
336331
"-d",
337332
"--dataset",

examples/qualcomm/oss_scripts/whisper/whisper.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -471,12 +471,6 @@ def post_process():
471471
type=int,
472472
)
473473

474-
parser.add_argument(
475-
"--pre_gen_pte",
476-
help="Run the pre-generated llama in the given directory.",
477-
type=str,
478-
)
479-
480474
args = parser.parse_args()
481475
args.validate(args)
482476

examples/qualcomm/qaihub_scripts/llama/llama2/qaihub_llama2_7b.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -230,13 +230,6 @@ def post_process():
230230
type=str,
231231
)
232232

233-
parser.add_argument(
234-
"--pre_gen_pte",
235-
help="folder path to pre-compiled ptes",
236-
default=None,
237-
type=str,
238-
)
239-
240233
args = parser.parse_args()
241234

242235
try:

examples/qualcomm/qaihub_scripts/llama/llama3/qaihub_llama3_8b.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,6 @@ def post_process():
240240
type=str,
241241
)
242242

243-
parser.add_argument(
244-
"--pre_gen_pte",
245-
help="folder path to pre-compiled ptes",
246-
default=None,
247-
type=str,
248-
)
249-
250243
args = parser.parse_args()
251244

252245
try:

0 commit comments

Comments
 (0)