Start profile delegate

Author: zhongmingyuan

devtools/etdump/etdump_flatcc.cpp

@@ -284,7 +284,7 @@ void ETDumpGen::end_profiling_delegate(
   etdump_RunData_events_push_end(builder_);
 }
 
-void ETDumpGen::log_profiling_delegate(
+Result<bool> ETDumpGen::log_profiling_delegate(
     const char* name,
     DelegateDebugIntId delegate_debug_index,
     et_timestamp_t start_time,
@@ -314,6 +314,7 @@ void ETDumpGen::log_profiling_delegate(
   etdump_RunData_events_push_start(builder_);
   etdump_Event_profile_event_add(builder_, id);
   etdump_RunData_events_push_end(builder_);
+  return Result<bool>(true);
 }
 
 Result<bool> ETDumpGen::log_intermediate_output_delegate(

devtools/etdump/etdump_flatcc.h

@@ -90,7 +90,7 @@ class ETDumpGen : public ::executorch::runtime::EventTracer {
       ::executorch::runtime::EventTracerEntry prof_entry,
       const void* metadata,
       size_t metadata_len) override;
-  virtual void log_profiling_delegate(
+  virtual Result<bool> log_profiling_delegate(
       const char* name,
       DelegateDebugIntId delegate_debug_index,
       et_timestamp_t start_time,

docs/source/delegate-debugging.md

@@ -113,7 +113,7 @@ ExecuTorch also allows you to log in post time. Some runtime settings don't have
 To log events in post (for example, logging start and end time simultaneously) `event_tracer_log_profiling_delegate` is called with a combination of the arguments used in the real-time logging API’s and timestamps.
 
 ```c++
-void event_tracer_log_profiling_delegate(
+Result<bool> event_tracer_log_profiling_delegate(
     EventTracer* event_tracer,
     const char* name,
     DebugHandle delegate_debug_id,

runtime/core/event_tracer.h

@@ -265,7 +265,7 @@ class EventTracer {
    * make it available for the user again in the post-processing stage.
    * @param[in] metadata_len Length of the metadata buffer.
    */
-  virtual void log_profiling_delegate(
+  virtual Result<bool> log_profiling_delegate(
       const char* name,
       DelegateDebugIntId delegate_debug_index,
       et_timestamp_t start_time,

runtime/core/event_tracer_hooks_delegate.h

@@ -124,7 +124,7 @@ inline void event_tracer_end_profiling_delegate(
  * make it available for the user again in the post-processing stage.
  * @param[in] metadata_len Length of the metadata buffer.
  */
-inline void event_tracer_log_profiling_delegate(
+inline Result<bool> event_tracer_log_profiling_delegate(
     EventTracer* event_tracer,
     const char* name,
     DebugHandle delegate_debug_id,
@@ -134,7 +134,7 @@ inline void event_tracer_log_profiling_delegate(
     size_t metadata_len = 0) {
 #ifdef ET_EVENT_TRACER_ENABLED
   if (event_tracer) {
-    event_tracer->log_profiling_delegate(
+    return event_tracer->log_profiling_delegate(
         name, delegate_debug_id, start_time, end_time, metadata, metadata_len);
   }
 #else //! ET_EVENT_TRACER_ENABLED
@@ -144,6 +144,7 @@ inline void event_tracer_log_profiling_delegate(
   (void)end_time;
   (void)metadata;
   (void)metadata_len;
+  return Result<bool>(false);
 #endif
 }
 

runtime/core/test/event_tracer_test.cpp

@@ -96,7 +96,7 @@ class DummyEventTracer : public EventTracer {
     (void)event_tracer_filter;
   }
 
-  void log_profiling_delegate(
+  Result<bool> log_profiling_delegate(
       const char* name,
       DelegateDebugIntId delegate_debug_id,
       et_timestamp_t start_time,
@@ -109,6 +109,7 @@ class DummyEventTracer : public EventTracer {
     (void)end_time;
     (void)metadata;
     (void)metadata_len;
+    return Result<bool>(true);
   }
 
   virtual Result<bool> log_intermediate_output_delegate(