Skip to content

Commit 12a33f6

Browse files
authored
Ready to land
1 parent c3db2a4 commit 12a33f6

File tree

1 file changed

+13
-18
lines changed

1 file changed

+13
-18
lines changed

.github/workflows/apple.yml

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -191,29 +191,26 @@ jobs:
191191
192192
upload-frameworks-ios:
193193
runs-on: ubuntu-22.04
194-
# needs: [build-frameworks-ios, set-version]
194+
needs: [build-frameworks-ios, set-version]
195195
timeout-minutes: 30
196-
# UNCOMMENT THIS LINE BEFORE LANDING
197-
# envionrment: ${{ (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/nightly') && 'cherry-pick-bot' || '' }}
198-
# FOR TESTING
199-
environment: cherry-pick-bot
196+
environment: ${{ (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/nightly') && 'cherry-pick-bot' || '' }}
200197
permissions:
201198
id-token: write
202199
contents: write
203200
steps:
204201
- uses: actions/checkout@v3
205202
with:
206203
fetch-depth: 0
207-
token: ${{ secrets.GH_PYTORCHBOT_CHERRY_PICK_TOKEN }}
204+
token: ${{ secrets.GH_PYTORCHBOT_CHERRY_PICK_TOKEN || secrets.GITHUB_TOKEN }}
208205
- uses: actions/setup-python@v4
209206
with:
210207
python-version: '3.11'
211208
cache: pip
212-
#- name: configure aws credentials
213-
# uses: aws-actions/[email protected]
214-
# with:
215-
# role-to-assume: arn:aws:iam::308535385114:role/gha_executorch_upload-frameworks-ios
216-
# aws-region: us-east-1
209+
- name: configure aws credentials
210+
uses: aws-actions/[email protected]
211+
with:
212+
role-to-assume: arn:aws:iam::308535385114:role/gha_executorch_upload-frameworks-ios
213+
aws-region: us-east-1
217214
- name: Download the artifact
218215
uses: actions/download-artifact@v3
219216
with:
@@ -226,8 +223,6 @@ jobs:
226223
run: |
227224
echo "UPLOAD_ON_MAIN=1" >> "${GITHUB_ENV}"
228225
- name: Upload the artifact to ossci-ios S3 bucket
229-
# DEBUG
230-
if: false
231226
shell: bash
232227
run: |
233228
set -eux
@@ -268,16 +263,16 @@ jobs:
268263
sed -i "s/__SHA256_${FRAMEWORK}__/${CHECKSUM}/g" Package.swift
269264
done < "${RUNNER_TEMP}/checksums.txt"
270265
271-
#if [[ "${UPLOAD_ON_MAIN:-0}" == "1" ]]; then
266+
if [[ "${UPLOAD_ON_MAIN:-0}" == "1" ]]; then
272267
git config --global user.name "PyTorch Bot"
273268
git config --global user.email "[email protected]"
274269
git add Package.swift
275270
git commit -m "${VERSION}"
276271
git push origin "${BRANCH}"
277-
#else
278-
# echo "Draft Package.swift:"
279-
# cat Package.swift
280-
#fi
272+
else
273+
echo "Draft Package.swift:"
274+
cat Package.swift
275+
fi
281276
282277
build-benchmark-app:
283278
name: build-benchmark-app

0 commit comments

Comments
 (0)