Skip to content

Commit 155d920

Browse files
authored
Remove MPS backend dependencies installation (#11237)
### Summary All `mps/install_requirements.sh` does is to install ninja — which is not used to build the MPS backend. ### Test plan CI
1 parent 7b53b88 commit 155d920

File tree

10 files changed

+1
-56
lines changed

10 files changed

+1
-56
lines changed

.ci/scripts/test_ios_ci.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ say "Installing CoreML Backend Requirements"
4242

4343
./backends/apple/coreml/scripts/install_requirements.sh
4444

45-
say "Installing MPS Backend Requirements"
46-
47-
./backends/apple/mps/install_requirements.sh
48-
4945
say "Exporting Models"
5046

5147
python3 -m examples.portable.scripts.export --model_name="$MODEL_NAME" --segment_alignment=0x4000

.github/workflows/apple-perf.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,6 @@ jobs:
188188
backends/apple/coreml/scripts/install_requirements.sh
189189
fi
190190
191-
if [[ ${{ matrix.config }} == *"mps"* ]]; then
192-
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
193-
backends/apple/mps/install_requirements.sh
194-
fi
195-
196191
# Install requirements for export_llama
197192
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash examples/models/llama/install_requirements.sh
198193
@@ -379,10 +374,6 @@ jobs:
379374
# Install CoreML Backend Requirements
380375
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
381376
backends/apple/coreml/scripts/install_requirements.sh
382-
383-
# Install MPS Backend Requirements
384-
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
385-
backends/apple/mps/install_requirements.sh
386377
echo "::endgroup::"
387378
388379
echo "::group::Build ExecuTorch iOS frameworks"

.github/workflows/apple.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,6 @@ jobs:
168168
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
169169
backends/apple/coreml/scripts/install_requirements.sh
170170
171-
# Install MPS Backend Requirements
172-
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
173-
backends/apple/mps/install_requirements.sh
174-
175171
# Build iOS Frameworks
176172
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output scripts/build_apple_frameworks.sh
177173
@@ -306,10 +302,6 @@ jobs:
306302
# Install CoreML Backend Requirements
307303
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
308304
backends/apple/coreml/scripts/install_requirements.sh
309-
310-
# Install MPS Backend Requirements
311-
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
312-
backends/apple/mps/install_requirements.sh
313305
echo "::endgroup::"
314306
315307
echo "::group::Build ExecuTorch iOS frameworks"

.github/workflows/trunk.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -414,11 +414,7 @@ jobs:
414414
# Setup executorch
415415
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh --build-tool cmake
416416
417-
if [[ "${MODE}" == "mps" ]]; then
418-
# Install mps delegate
419-
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash backends/apple/mps/install_requirements.sh
420-
echo "Finishing installing mps."
421-
elif [[ "${MODE}" == "coreml" ]]; then
417+
if [[ "${MODE}" == "coreml" ]]; then
422418
# Install coreml delegate
423419
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash backends/apple/coreml/scripts/install_requirements.sh
424420
echo "Finishing installing coreml."
@@ -504,8 +500,6 @@ jobs:
504500
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh --build-tool "${BUILD_TOOL}"
505501
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash backends/apple/coreml/scripts/install_requirements.sh
506502
echo "Finishing installing coreml."
507-
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash backends/apple/mps/install_requirements.sh
508-
echo "Finishing installing mps."
509503
510504
# Build and test coreml model
511505
MODELS=(mv3 ic4 resnet50 edsr mobilebert w2l)

backends/apple/mps/install_requirements.sh

Lines changed: 0 additions & 8 deletions
This file was deleted.

backends/apple/mps/setup.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,6 @@ In order to be able to successfully build and run a model using the MPS backend
4242

4343
***Step 1.*** Please finish tutorial [Setting up ExecuTorch](https://pytorch.org/executorch/main/getting-started-setup).
4444

45-
***Step 2.*** Install dependencies needed to lower MPS delegate:
46-
47-
```bash
48-
./backends/apple/mps/install_requirements.sh
49-
```
50-
5145
## Build
5246

5347
### AOT (Ahead-of-time) Components

docs/source/backends-mps.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,6 @@ In order to be able to successfully build and run a model using the MPS backend
4242

4343
***Step 1.*** Please finish tutorial [Getting Started](getting-started.md).
4444

45-
***Step 2.*** Install dependencies needed to lower MPS delegate:
46-
47-
```bash
48-
./backends/apple/mps/install_requirements.sh
49-
```
50-
5145
## Build
5246

5347
### AOT (Ahead-of-time) Components

docs/source/using-executorch-ios.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,6 @@ python3 -m venv .venv && source .venv/bin/activate && pip install --upgrade pip
112112

113113
# CoreML-only requirements:
114114
./backends/apple/coreml/scripts/install_requirements.sh
115-
116-
# MPS-only requirements:
117-
./backends/apple/mps/install_requirements.sh
118115
```
119116

120117
5. Install [CMake](https://cmake.org):

examples/demo-apps/apple_ios/LLaMA/docs/delegates/mps_README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ Install dependencies
3636

3737
```
3838
./install_executorch.sh
39-
./backends/apple/mps/install_requirements.sh
4039
```
4140

4241
## Prepare Models

scripts/test_ios.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@ say "Installing CoreML Backend Requirements"
6060

6161
./backends/apple/coreml/scripts/install_requirements.sh
6262

63-
say "Installing MPS Backend Requirements"
64-
65-
./backends/apple/mps/install_requirements.sh
66-
6763
say "Exporting Models"
6864

6965
python3 -m examples.portable.scripts.export --model_name="$MODEL_NAME"

0 commit comments

Comments
 (0)