Core runtime changes for Windows MSVC support (#6624)

Summary:
Miscellaneous core runtime fixes to make sure we can build with MSVC.


Differential Revision: D65328601

Author: tarun292

kernels/quantized/cpu/op_quantize.cpp

@@ -281,7 +281,7 @@ Tensor& quantize_per_channel_out(
   check_quantize_per_tensor_args(input, quant_min, quant_max, dtype, out);
 
   // a list contains all dimensions except axis
-  int64_t dims[input.dim() - 1];
+  int64_t dims[kTensorDimensionLimit];
   for (int64_t i = 0; i < input.dim() - 1; i++) {
     if (i < axis) {
       dims[i] = i;

runtime/core/portable_type/tensor_impl.cpp

@@ -110,8 +110,11 @@ Error TensorImpl::internal_resize_contiguous(ArrayRef<SizesType> new_sizes) {
           numel_bound_);
 
       if (strides_ && dim_order_) {
-        ET_CHECK_OK_OR_RETURN_ERROR(
-            dim_order_to_stride(new_sizes.data(), dim_order_, dim_, strides_));
+        auto error =
+            dim_order_to_stride(new_sizes.data(), dim_order_, dim_, strides_);
+        if (error != Error::Ok) {
+          return error;
+        }
       }
       numel_ = new_numel;
       std::copy(new_sizes.begin(), new_sizes.end(), sizes_);

runtime/executor/memory_manager.h

@@ -67,11 +67,7 @@ class MemoryManager final {
    * TODO(T162089316): Remove this once all users migrate to the new ctor.
    */
   ET_DEPRECATED MemoryManager(
-      // We would normally use ET_UNUSED here, but GCC older than 9.3 has a
-      // bug that triggers a syntax error when using [[maybe_unused]] on the
-      // first parameter of a constructor:
-      // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81429
-      __attribute__((unused)) MemoryAllocator* constant_allocator,
+      ET_UNUSED MemoryAllocator* constant_allocator,
       HierarchicalAllocator* non_constant_allocator,
       MemoryAllocator* runtime_allocator,
       MemoryAllocator* temporary_allocator)

runtime/executor/program.cpp

@@ -86,7 +86,11 @@ Result<executorch_flatbuffer::ExecutionPlan*> get_execution_plan(
     } else if (eh.error() == Error::NotFound) {
       // No header; the program consumes the whole file, and there are no
       // segments.
-      program_size = ET_UNWRAP(loader->size());
+      auto result = loader->size();
+      if (!result.ok()) {
+        return result.error();
+      }
+      program_size = result.get();
     } else {
       ET_LOG(Error, "Extended header may be corrupt");
       return eh.error();

runtime/platform/compiler.h

@@ -80,7 +80,15 @@
   [[deprecated("This API is experimental and may change without notice.")]]
 #define ET_FALLTHROUGH [[fallthrough]]
 #define ET_NODISCARD [[nodiscard]]
+
+#if defined(__GNUC__) && (__GNUC__ < 9 || (__GNUC__ == 9 && __GNUC_MINOR__ < 3))
+// GCC older than 9.3 has a bug that triggers a syntax error when using [[maybe_unused]]
+// on the first parameter of a constructor:
+// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81429
+#define ET_UNUSED __attribute__((unused))
+#else
 #define ET_UNUSED [[maybe_unused]]
+#endif
 
 // UNLIKELY Macro
 // example