Skip to content

Commit 19e8654

Browse files
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Extensions (#16526)
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #16479 by @GregoryComer ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/172/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/172/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/171/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/172/orig Differential Revision: [D89902030](https://our.internmc.facebook.com/intern/diff/D89902030/) @diff-train-skip-merge --------- Co-authored-by: Gregory Comer <[email protected]>
1 parent e97f3e9 commit 19e8654

File tree

28 files changed

+50
-188
lines changed

28 files changed

+50
-188
lines changed

extension/android/jni/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ non_fbcode_target(_kind = runtime.cxx_library,
131131
deps = [
132132
"//executorch/runtime/core:core",
133133
],
134-
visibility = ["@EXECUTORCH_CLIENTS"],
134+
visibility = ["PUBLIC"],
135135
)
136136

137137
runtime.export_file(

extension/aten_util/targets.bzl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,7 @@ def define_common_targets():
2121
"-Wno-global-constructors",
2222
"-Wno-unused-function",
2323
],
24-
visibility = [
25-
"//executorch/...",
26-
"@EXECUTORCH_CLIENTS",
27-
],
24+
visibility = ["PUBLIC"],
2825
exported_deps = [
2926
"//executorch/extension/kernel_util:kernel_util",
3027
"//executorch/extension/tensor:tensor",

extension/data_loader/targets.bzl

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,7 @@ def define_common_targets():
1111
name = "buffer_data_loader",
1212
srcs = [],
1313
exported_headers = ["buffer_data_loader.h"],
14-
visibility = [
15-
"//executorch/exir/backend/test/...",
16-
"//executorch/runtime/executor/test/...",
17-
"//executorch/extension/pybindings/...",
18-
"//executorch/test/...",
19-
"//executorch/extension/data_loader/test/...",
20-
"@EXECUTORCH_CLIENTS",
21-
],
14+
visibility = ["PUBLIC"],
2215
exported_deps = [
2316
"//executorch/runtime/core:core",
2417
],
@@ -28,10 +21,7 @@ def define_common_targets():
2821
name = "shared_ptr_data_loader",
2922
srcs = [],
3023
exported_headers = ["shared_ptr_data_loader.h"],
31-
visibility = [
32-
"@EXECUTORCH_CLIENTS",
33-
"//executorch/extension/data_loader/test/...",
34-
],
24+
visibility = ["PUBLIC"],
3525
exported_deps = [
3626
"//executorch/runtime/core:core",
3727
],
@@ -41,12 +31,7 @@ def define_common_targets():
4131
name = "file_data_loader",
4232
srcs = ["file_data_loader.cpp"],
4333
exported_headers = ["file_data_loader.h"],
44-
visibility = [
45-
"//executorch/test/...",
46-
"//executorch/runtime/executor/test/...",
47-
"//executorch/extension/data_loader/test/...",
48-
"@EXECUTORCH_CLIENTS",
49-
],
34+
visibility = ["PUBLIC"],
5035
exported_deps = [
5136
"//executorch/runtime/core:core",
5237
],
@@ -56,12 +41,7 @@ def define_common_targets():
5641
name = "file_descriptor_data_loader",
5742
srcs = ["file_descriptor_data_loader.cpp"],
5843
exported_headers = ["file_descriptor_data_loader.h"],
59-
visibility = [
60-
"//executorch/test/...",
61-
"//executorch/runtime/executor/test/...",
62-
"//executorch/extension/data_loader/test/...",
63-
"@EXECUTORCH_CLIENTS",
64-
],
44+
visibility = ["PUBLIC"],
6545
exported_deps = [
6646
"//executorch/runtime/core:core",
6747
],
@@ -83,13 +63,7 @@ def define_common_targets():
8363
"mman.h",
8464
"mmap_data_loader.h"
8565
],
86-
visibility = [
87-
"//executorch/test/...",
88-
"//executorch/extension/pybindings/...",
89-
"//executorch/runtime/executor/test/...",
90-
"//executorch/extension/data_loader/test/...",
91-
"@EXECUTORCH_CLIENTS",
92-
],
66+
visibility = ["PUBLIC"],
9367
exported_deps = [
9468
"//executorch/runtime/core:core",
9569
],

extension/evalue_util/targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def define_common_targets():
1414
name = "print_evalue" + aten_suffix,
1515
srcs = ["print_evalue.cpp"],
1616
exported_headers = ["print_evalue.h"],
17-
visibility = ["@EXECUTORCH_CLIENTS"],
17+
visibility = ["PUBLIC"],
1818
exported_deps = [
1919
"//executorch/runtime/core:evalue" + aten_suffix,
2020
],

extension/export_util/TARGETS

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,7 @@ runtime.python_library(
88
"utils.py",
99
],
1010
_is_external_target = True,
11-
visibility = [
12-
"//bento/...",
13-
"//bento_kernels/...",
14-
"//executorch/...",
15-
"@EXECUTORCH_CLIENTS",
16-
],
11+
visibility = ["PUBLIC"],
1712
deps = [
1813
"//caffe2:torch",
1914
"//executorch/exir:lib",

extension/flat_tensor/serialize/TARGETS

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,7 @@ runtime.python_library(
2727
"flat_tensor.fbs",
2828
"scalar_type.fbs",
2929
],
30-
visibility = [
31-
"//executorch/...",
32-
"@EXECUTORCH_CLIENTS",
33-
],
30+
visibility = ["PUBLIC"],
3431
deps = [
3532
":schema",
3633
"//executorch/exir/_serialize:lib",

extension/flat_tensor/serialize/targets.bzl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ def define_common_targets():
5454
"//executorch/runtime/core/exec_aten:lib",
5555
],
5656
exported_headers = ["serialize.h"],
57-
visibility = [
58-
"//executorch/...",
59-
"@EXECUTORCH_CLIENTS",
60-
],
57+
visibility = ["PUBLIC"],
6158
exported_external_deps = ["flatbuffers-api"],
6259
)

extension/flat_tensor/targets.bzl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,5 @@ def define_common_targets():
2020
"//executorch/extension/flat_tensor/serialize:flat_tensor_header",
2121
"//executorch/extension/flat_tensor/serialize:generated_headers",
2222
],
23-
visibility = [
24-
"@EXECUTORCH_CLIENTS",
25-
],
23+
visibility = ["PUBLIC"],
2624
)

extension/kernel_util/targets.bzl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ def define_common_targets():
1515
"meta_programming.h",
1616
"type_list.h",
1717
],
18-
visibility = [
19-
"//executorch/...",
20-
"@EXECUTORCH_CLIENTS",
21-
],
18+
visibility = ["PUBLIC"],
2219
exported_deps = [
2320
"//executorch/runtime/core:core",
2421
"//executorch/runtime/core:evalue",

extension/llm/custom_ops/spinquant/targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ def define_common_targets():
1818
exported_deps = [
1919
"//executorch/extension/llm/custom_ops/spinquant/third-party/FFHT:fht",
2020
],
21-
visibility = ["@EXECUTORCH_CLIENTS"],
21+
visibility = ["PUBLIC"],
2222
)

0 commit comments

Comments
 (0)