Skip to content

Commit 1ab677d

Browse files
kimishpatelkimishpatel
committed
Update on "[Executorch] enable sleef consistently"
Earlier only android platofrms had support for sleef Differential Revision: [D64571782](https://our.internmc.facebook.com/intern/diff/D64571782/) [ghstack-poisoned]
2 parents eed0fb2 + 45b0333 commit 1ab677d

File tree

124 files changed

+3082
-725
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

124 files changed

+3082
-725
lines changed

‎.github/workflows/ghstack_land.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ on:
1111
- 'gh/kimishpatel/[0-9]+/base'
1212
- 'gh/kirklandsign/[0-9]+/base'
1313
- 'gh/larryliu0820/[0-9]+/base'
14+
- 'gh/lucylq/[0-9]+/base'
1415
- 'gh/manuelcandales/[0-9]+/base'
1516
- 'gh/mcr229/[0-9]+/base'
1617
- 'gh/swolchok/[0-9]+/base'

‎.github/workflows/pull.yml‎

Lines changed: 11 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ jobs:
3535
name: test-setup-linux-gcc
3636
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
3737
strategy:
38-
matrix:
39-
include:
40-
- build-tool: cmake
4138
fail-fast: false
4239
with:
4340
runner: linux.2xlarge
@@ -50,7 +47,7 @@ jobs:
5047
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
5148
conda activate "${CONDA_ENV}"
5249
53-
BUILD_TOOL=${{ matrix.build-tool }}
50+
BUILD_TOOL="cmake"
5451
5552
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "${BUILD_TOOL}"
5653
# Build and test ExecuTorch with the add model on portable backend.
@@ -89,20 +86,11 @@ jobs:
8986
strategy:
9087
matrix:
9188
dtype: [fp32]
92-
build-tool: [buck2, cmake]
9389
mode: [portable, xnnpack+custom, xnnpack+custom+qe]
9490
include:
9591
- dtype: bf16
96-
build-tool: cmake
97-
mode: portable
98-
- dtype: bf16
99-
build-tool: buck2
10092
mode: portable
10193
- dtype: bf16
102-
build-tool: cmake
103-
mode: custom
104-
- dtype: bf16
105-
build-tool: buck2
10694
mode: custom
10795
fail-fast: false
10896
with:
@@ -117,11 +105,11 @@ jobs:
117105
conda activate "${CONDA_ENV}"
118106
119107
DTYPE=${{ matrix.dtype }}
120-
BUILD_TOOL=${{ matrix.build-tool }}
108+
BUILD_TOOL="cmake"
121109
MODE=${{ matrix.mode }}
122110
123111
# Setup executorch
124-
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh buck2
112+
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "${BUILD_TOOL}"
125113
# Install requirements for export_llama
126114
PYTHON_EXECUTABLE=python bash examples/models/llama/install_requirements.sh
127115
# Test llama2
@@ -131,9 +119,6 @@ jobs:
131119
name: test-llama-runner-linux-android
132120
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
133121
strategy:
134-
matrix:
135-
include:
136-
- build-tool: cmake
137122
fail-fast: false
138123
with:
139124
runner: linux.2xlarge
@@ -146,18 +131,14 @@ jobs:
146131
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
147132
conda activate "${CONDA_ENV}"
148133
149-
BUILD_TOOL=${{ matrix.build-tool }}
134+
BUILD_TOOL="cmake"
150135
PYTHON_EXECUTABLE=python \
151136
bash .ci/scripts/build_llama_android.sh "${BUILD_TOOL}"
152137
153138
test-custom-ops-linux:
154139
name: test-custom-ops-linux
155140
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
156141
strategy:
157-
matrix:
158-
include:
159-
- build-tool: buck2
160-
- build-tool: cmake
161142
fail-fast: false
162143
with:
163144
runner: linux.2xlarge
@@ -170,7 +151,7 @@ jobs:
170151
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
171152
conda activate "${CONDA_ENV}"
172153
173-
BUILD_TOOL=${{ matrix.build-tool }}
154+
BUILD_TOOL="cmake"
174155
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "${BUILD_TOOL}"
175156
# Test custom ops
176157
PYTHON_EXECUTABLE=python bash examples/portable/custom_ops/test_custom_ops.sh "${BUILD_TOOL}"
@@ -179,10 +160,6 @@ jobs:
179160
name: test-selective-build-linux
180161
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
181162
strategy:
182-
matrix:
183-
include:
184-
- build-tool: buck2
185-
- build-tool: cmake
186163
fail-fast: false
187164
with:
188165
runner: linux.2xlarge
@@ -195,7 +172,7 @@ jobs:
195172
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
196173
conda activate "${CONDA_ENV}"
197174
198-
BUILD_TOOL=${{ matrix.build-tool }}
175+
BUILD_TOOL="cmake"
199176
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "${BUILD_TOOL}"
200177
# Test selective build
201178
PYTHON_EXECUTABLE=python bash examples/selective_build/test_selective_build.sh "${BUILD_TOOL}"
@@ -235,9 +212,6 @@ jobs:
235212
name: test-quantized-aot-lib-linux
236213
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
237214
strategy:
238-
matrix:
239-
include:
240-
- build-tool: cmake
241215
fail-fast: false
242216
with:
243217
runner: linux.2xlarge
@@ -250,17 +224,14 @@ jobs:
250224
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
251225
conda activate "${CONDA_ENV}"
252226
253-
BUILD_TOOL=${{ matrix.build-tool }}
227+
BUILD_TOOL="cmake"
254228
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "${BUILD_TOOL}"
255229
PYTHON_EXECUTABLE=python bash examples/xnnpack/quantization/test_quantize.sh "${BUILD_TOOL}" mv2
256230
257231
test-pybind-build-linux:
258232
name: test-pybind-build-linux
259233
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
260234
strategy:
261-
matrix:
262-
include:
263-
- build-tool: cmake
264235
fail-fast: false
265236
with:
266237
runner: linux.2xlarge
@@ -274,7 +245,7 @@ jobs:
274245
conda activate "${CONDA_ENV}"
275246
276247
# build module for executorch.extension.pybindings.portable_lib
277-
BUILD_TOOL=${{ matrix.build-tool }}
248+
BUILD_TOOL="cmake"
278249
PYTHON_EXECUTABLE=python \
279250
EXECUTORCH_BUILD_XNNPACK=ON \
280251
EXECUTORCH_BUILD_PYBIND=ON \
@@ -357,10 +328,6 @@ jobs:
357328

358329
unittest-arm:
359330
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
360-
strategy:
361-
matrix:
362-
include:
363-
- build-tool: buck2
364331
with:
365332
runner: linux.2xlarge
366333
docker-image: executorch-ubuntu-22.04-arm-sdk
@@ -374,7 +341,7 @@ jobs:
374341
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
375342
conda activate "${CONDA_ENV}"
376343
377-
BUILD_TOOL=${{ matrix.build-tool }}
344+
BUILD_TOOL="cmake"
378345
379346
# Setup MacOS dependencies as there is no Docker support on MacOS atm
380347
PYTHON_EXECUTABLE=python \
@@ -396,7 +363,6 @@ jobs:
396363
strategy:
397364
matrix:
398365
dtype: [fp32]
399-
build-tool: [cmake]
400366
mode: [qnn]
401367
fail-fast: false
402368
with:
@@ -411,14 +377,14 @@ jobs:
411377
conda activate "${CONDA_ENV}"
412378
413379
DTYPE=${{ matrix.dtype }}
414-
BUILD_TOOL=${{ matrix.build-tool }}
380+
BUILD_TOOL="cmake"
415381
MODE=${{ matrix.mode }}
416382
417383
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh
418384
PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh
419385
420386
# Setup executorch
421-
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh buck2
387+
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "${BUILD_TOOL}"
422388
# Install requirements for export_llama
423389
PYTHON_EXECUTABLE=python bash examples/models/llama/install_requirements.sh
424390
# Test llama2

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ tools.
9292
├── runtime # Core C++ runtime.
9393
| ├── backend # Backend delegate runtime APIs.
9494
| ├── core # Core structures used across all levels of the runtime.
95-
| ├── executor # Model loading, initalization, and execution.
95+
| ├── executor # Model loading, initialization, and execution.
9696
| ├── kernel # Kernel registration and management.
9797
| ├── platform # Layer between architecture specific code and portable C++.
9898
├── schema # ExecuTorch PTE file format flatbuffer

‎backends/apple/coreml/compiler/coreml_preprocess.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,12 +425,15 @@ def preprocess(
425425
CoreMLBackend.op_linear_quantizer_config_from_compile_specs(compile_specs)
426426
)
427427

428+
# Load the model if MODEL_TYPE is 'COMPILED_MODEL'. This step is necessary because
429+
# get_compiled_model_path() requires a loaded model.
430+
skip_model_load = model_type != CoreMLBackend.MODEL_TYPE.COMPILED_MODEL
428431
mlmodel = ct.convert(
429432
model=edge_program,
430433
source="pytorch",
431434
convert_to="mlprogram",
432435
pass_pipeline=ct.PassPipeline.DEFAULT,
433-
skip_model_load=True,
436+
skip_model_load=skip_model_load,
434437
compute_precision=model_compute_precision,
435438
minimum_deployment_target=minimum_deployment_target,
436439
compute_units=compute_units,

‎backends/apple/coreml/runtime/delegate/backend_delegate.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class BackendDelegate {
2828
// Max models cache size in bytes.
2929
size_t max_models_cache_size = 10 * size_t(1024) * size_t(1024) * size_t(1024);
3030
// If set to `true`, delegate pre-warms the most recently used asset.
31-
bool should_prewarm_asset = true;
31+
bool should_prewarm_asset = false;
3232
// If set to `true`, delegate pre-warms the model in `init`.
3333
bool should_prewarm_model = true;
3434
};

‎backends/apple/coreml/runtime/delegate/com.apple.executorchcoreml_config.plist‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<plist version="1.0">
44
<dict>
55
<key>shouldPrewarmAsset</key>
6-
<true/>
6+
<false/>
77
<key>shouldPrewarmModel</key>
88
<true/>
99
<key>maxAssetsSizeInBytes</key>

‎backends/apple/coreml/runtime/test/CoreMLBackendDelegateTests.mm‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,12 @@ - (void)testStateProgramExecute {
209209
}
210210
#endif
211211

212+
- (void)testAddMulCompiledProgramExecute {
213+
NSURL *modelURL = [[self class] bundledResourceWithName:@"add_mul_compiled_coreml_all" extension:@"pte"];
214+
XCTAssertNotNil(modelURL);
215+
[self executeModelAtURL:modelURL nLoads:1 nExecutions:2];
216+
}
217+
212218
- (void)executeMultipleModelsConcurrently:(NSArray<NSURL *> *)modelURLs
213219
nLoads:(NSUInteger)nLoads
214220
nExecutions:(NSUInteger)nExecutions

‎backends/apple/coreml/runtime/workspace/executorchcoreml.xcodeproj/project.pbxproj‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
/* Begin PBXBuildFile section */
1010
8307EB8A2C9262060011AE6D /* state_coreml_all.pte in Resources */ = {isa = PBXBuildFile; fileRef = 8307EB892C9262060011AE6D /* state_coreml_all.pte */; };
11+
838CA6872CD1965700462190 /* add_mul_compiled_coreml_all.pte in Resources */ = {isa = PBXBuildFile; fileRef = 838CA6862CD1965700462190 /* add_mul_compiled_coreml_all.pte */; };
1112
83BB78A02C65DA7300274ED7 /* ETCoreMLModelDebugInfo.mm in Sources */ = {isa = PBXBuildFile; fileRef = 83BB789F2C65DA7300274ED7 /* ETCoreMLModelDebugInfo.mm */; };
1213
83BB78BF2C66AAAE00274ED7 /* add_mul_coreml_all.bin in Resources */ = {isa = PBXBuildFile; fileRef = 83BB78BD2C66AAAE00274ED7 /* add_mul_coreml_all.bin */; };
1314
83BB78C02C66AAAE00274ED7 /* add_mul_coreml_all.pte in Resources */ = {isa = PBXBuildFile; fileRef = 83BB78BE2C66AAAE00274ED7 /* add_mul_coreml_all.pte */; };
@@ -122,6 +123,7 @@
122123

123124
/* Begin PBXFileReference section */
124125
8307EB892C9262060011AE6D /* state_coreml_all.pte */ = {isa = PBXFileReference; lastKnownFileType = file; name = state_coreml_all.pte; path = ../test/models/state_coreml_all.pte; sourceTree = "<group>"; };
126+
838CA6862CD1965700462190 /* add_mul_compiled_coreml_all.pte */ = {isa = PBXFileReference; lastKnownFileType = file; name = add_mul_compiled_coreml_all.pte; path = ../test/models/add_mul_compiled_coreml_all.pte; sourceTree = "<group>"; };
125127
83BB789E2C65DA7300274ED7 /* ETCoreMLModelDebugInfo.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = ETCoreMLModelDebugInfo.h; path = ../sdk/ETCoreMLModelDebugInfo.h; sourceTree = "<group>"; };
126128
83BB789F2C65DA7300274ED7 /* ETCoreMLModelDebugInfo.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = ETCoreMLModelDebugInfo.mm; path = ../sdk/ETCoreMLModelDebugInfo.mm; sourceTree = "<group>"; };
127129
83BB78BD2C66AAAE00274ED7 /* add_mul_coreml_all.bin */ = {isa = PBXFileReference; lastKnownFileType = archive.macbinary; name = add_mul_coreml_all.bin; path = ../test/models/add_mul_coreml_all.bin; sourceTree = "<group>"; };
@@ -606,6 +608,7 @@
606608
C98551992AD2542D009143F9 /* mul_coreml_all.bin */,
607609
C985519C2AD2542D009143F9 /* mul_coreml_all.pte */,
608610
C985519B2AD2542D009143F9 /* mv3_coreml_all.bin */,
611+
838CA6862CD1965700462190 /* add_mul_compiled_coreml_all.pte */,
609612
C98551982AD2542D009143F9 /* mv3_coreml_all.pte */,
610613
83BB78BD2C66AAAE00274ED7 /* add_mul_coreml_all.bin */,
611614
83BB78BE2C66AAAE00274ED7 /* add_mul_coreml_all.pte */,
@@ -680,6 +683,7 @@
680683
C985519E2AD2542D009143F9 /* mv3_coreml_all.pte in Resources */,
681684
C98551A02AD2542D009143F9 /* add_coreml_all.bin in Resources */,
682685
C98551A22AD2542D009143F9 /* mul_coreml_all.pte in Resources */,
686+
838CA6872CD1965700462190 /* add_mul_compiled_coreml_all.pte in Resources */,
683687
8307EB8A2C9262060011AE6D /* state_coreml_all.pte in Resources */,
684688
C98551A32AD2542D009143F9 /* add_coreml_all.pte in Resources */,
685689
);

‎backends/apple/coreml/scripts/generate_test_models.sh‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,12 @@ done
3131

3232
echo "Executorch: Generating stateful model"
3333
python3 "$SCRIPT_DIR_PATH/../runtime/test/export_stateful_model.py"
34+
35+
COMPILE_MODELS=("add_mul")
36+
echo "Executorch: Generating compiled model"
37+
for MODEL in "${COMPILE_MODELS[@]}"
38+
do
39+
echo "Executorch: Generating compiled $MODEL model"
40+
python3 -m examples.apple.coreml.scripts.export --model_name "$MODEL" --compile
41+
mv -f "$MODEL""_compiled_coreml_all.pte" "$COREML_DIR_PATH/runtime/test/models"
42+
done

‎backends/arm/_passes/arm_pass_manager.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
AnnotateChannelsLastDimOrder,
1313
)
1414
from executorch.backends.arm._passes.cast_int64_pass import CastInt64ToInt32Pass
15+
from executorch.backends.arm._passes.conv1d_unsqueeze_pass import Conv1dUnsqueezePass
1516
from executorch.backends.arm._passes.convert_expand_copy_to_repeat import (
1617
ConvertExpandCopyToRepeatPass,
1718
)
@@ -69,6 +70,7 @@ def transform_to_backend_pipeline(
6970
self.add_pass(DecomposeDivPass())
7071
self.add_pass(InsertSqueezeAfterSumPass())
7172
self.add_pass(ConvertSplitToSlicePass())
73+
self.add_pass(Conv1dUnsqueezePass(exported_program))
7274
self.add_pass(DecomposeSoftmaxesPass())
7375
for spec in compile_spec:
7476
if spec.key == "permute_memory_format":

0 commit comments

Comments
 (0)