Update on "[ET-VK] High dim tensor support for view, unsqueeze, squeeze, clone"

Differential Revision: [D80800084](https://our.internmc.facebook.com/intern/diff/D80800084)

[ghstack-poisoned]

Author: ssjia

backends/vulkan/runtime/api/containers/Tensor.cpp

@@ -722,17 +722,17 @@ uint32_t vTensor::UniformData::write_attribute(
 }
 
 vTensor::BufferMetadata::BufferMetadata(
-    std::vector<int64_t> src_sizes,
-    std::vector<int64_t> src_dim_order,
-    std::vector<int64_t> src_strides,
+    std::vector<int64_t>& src_sizes,
+    std::vector<int64_t>& src_dim_order,
+    std::vector<int64_t>& src_strides,
     size_t src_numel) {
   update(src_sizes, src_dim_order, src_strides, src_numel);
 }
 
 void vTensor::BufferMetadata::update(
-    std::vector<int64_t> src_sizes,
-    std::vector<int64_t> src_dim_order,
-    std::vector<int64_t> src_strides,
+    std::vector<int64_t>& src_sizes,
+    std::vector<int64_t>& src_dim_order,
+    std::vector<int64_t>& src_strides,
     size_t src_numel) {
   int32_t fixed_ndim = utils::safe_downcast<int32_t>(kTensorDimLimit);
 

backends/vulkan/runtime/api/containers/Tensor.h

@@ -248,7 +248,7 @@ class vTensor final {
     UniformData(
         const size_t numel_ll,
         const std::vector<int64_t>& sizes,
-        const std::vector<int64_t>& whcn_dim_order,
+        const std::vector<int64_t>& dim_order,
         const std::vector<int64_t>& strides,
         const utils::uvec3& limits);
 
@@ -272,15 +272,15 @@ class vTensor final {
     uint32_t numel;
 
     BufferMetadata(
-        std::vector<int64_t> sizes,
-        std::vector<int64_t> dim_order,
-        std::vector<int64_t> strides,
+        std::vector<int64_t>& sizes,
+        std::vector<int64_t>& dim_order,
+        std::vector<int64_t>& strides,
         size_t numel);
 
     void update(
-        std::vector<int64_t> sizes,
-        std::vector<int64_t> dim_order,
-        std::vector<int64_t> strides,
+        std::vector<int64_t>& sizes,
+        std::vector<int64_t>& dim_order,
+        std::vector<int64_t>& strides,
         size_t numel);
   };
 
@@ -355,7 +355,7 @@ class vTensor final {
   ParamsBuffer uniforms_;
 
   /*
-   * TODO: explain
+   * Used to store data for BufferMetadata to pass to shaders as buffer_meta_ubo
    */
   ParamsBuffer buffer_meta_;
 

backends/vulkan/runtime/graph/ops/impl/View.cpp

@@ -93,8 +93,8 @@ void add_view_copy_buffer_node(
     ComputeGraph& graph,
     ValueRef in,
     ValueRef out,
-    std::vector<ValueRef>& resize_args,
-    ExecuteNode::ResizeFunction resize_fn) {
+    const std::vector<ValueRef>& resize_args,
+    const ExecuteNode::ResizeFunction& resize_fn) {
   std::string kernel_name = "view_buffer";
   add_dtype_suffix(kernel_name, graph.dtype_of(out));
 

backends/vulkan/runtime/graph/ops/impl/View.h

@@ -21,8 +21,8 @@ void add_view_copy_buffer_node(
     ComputeGraph& graph,
     ValueRef in,
     ValueRef out,
-    std::vector<ValueRef>& resize_args,
-    ExecuteNode::ResizeFunction resize_fn);
+    const std::vector<ValueRef>& resize_args,
+    const ExecuteNode::ResizeFunction& resize_fn);
 
 void add_view_node(
     ComputeGraph& graph,